From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEDAC43217 for ; Thu, 20 Oct 2022 14:40:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229730AbiJTOkg (ORCPT ); Thu, 20 Oct 2022 10:40:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbiJTOke (ORCPT ); Thu, 20 Oct 2022 10:40:34 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E97FB139C2C for ; Thu, 20 Oct 2022 07:40:29 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 29KEdmUl009069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Oct 2022 10:39:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1666276789; bh=kG1ree45kEImwHBAJ1rz5gdQQphkhdtRHQIe70Qv3bQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Bt6zkpa0llmvbW8hygwCb6IzIQFAarbADX+6SD4I9Gf9VczYrRa/22Q23QAkXffRt A1LoTxldWA6YQeUhMp35reOCWxzjy3QPvUsJhPyedjV2C2bPF7WvpkfDQ3UCtPHLrk 9JjzmiZHA86Nn9jpNWSPdo6lP7WisDjFZPEJqnff/TVYCE9a53uqF+VNpSHurf83mj uGgliJsNUMLzktOo/XCGx3KU5P4nybYfAO5EDUWhU3JGkAEbORx0l0qH9h+TGQ+mV2 yBMNpOfUNw/djKpwE1DkuO8Y83pm+smQHATBeZGaXEmDgTQsnvy4fN6OLB5vPKpSg6 fzyeFCHnSvyLg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id DEEA415C3AD1; Thu, 20 Oct 2022 10:39:47 -0400 (EDT) Date: Thu, 20 Oct 2022 10:39:47 -0400 From: "Theodore Ts'o" To: Greg KH Cc: Tanju Brunostar , Bhaskar Chowdhury , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev Subject: Re: Request for assistance Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tanju, some additional hints. First of all, please don't send cleanup patches to address checkpatch --file complaints about overly long lines. It's generally not worth the code churn. Secondly for code that *you* are writing, think about why you have lines which are exceeding the line width in the first place. Is it because code is being nested too deeply, and perhaps some judicious function refactoring with good function names might make the code clearer? Would adding some temporary variables that are judiciously named make the code look clearer? The rules about "thou shalt never have lines which exceed 78 characters" are rules of thumb. The high level goal is to make the code more readable and easier to understand, since good code is maintainable code. And sometimes it's not just about where to split lines of code but whether there is a better way to structure the code so that long lines aren't needed in the first place. Cheers, - Ted