From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB78C433FE for ; Thu, 20 Oct 2022 15:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbiJTPAR (ORCPT ); Thu, 20 Oct 2022 11:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiJTPAM (ORCPT ); Thu, 20 Oct 2022 11:00:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DDCCE09EB for ; Thu, 20 Oct 2022 08:00:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DBFFE61BD2 for ; Thu, 20 Oct 2022 15:00:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA82FC433D6; Thu, 20 Oct 2022 15:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666278008; bh=OFeNuLuhtNbSF5lAejx5iAH9B5SR/HHR8g8Rex0/S58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T/6TAO9OZLddLi7hzNQ47kbDUwdm7xxtYbNCQMheQOcTumx9B1KNEbCTaY/QEqGHN ibgfrsLxebQ4CatSanQ9Mw8rh3RCwa97hjO7N/b13PrfawzdL0EGo45RoPtH1ob665 z9I/3d4e3DW9/5LwjVi7U3636RyVNjur3y+i5azM= Date: Thu, 20 Oct 2022 17:00:05 +0200 From: Greg KH To: Tanjuate Brunostar Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH v3] staging: vt6655: Fix Lines should not end with a '(' Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 11:30:36AM +0000, Tanjuate Brunostar wrote: > Code style warnings reported by checkpatch. > Improve the layout of a function header: > Put the first parameter immediately after the '(' and align the other > parameters underneath it. > > Signed-off-by: Tanjuate Brunostar > > --- > v2: put static and void on the same line and adjusted the indentation as > suggested by Greg KH > --- > v3: Reformat the code by inserting tabs and white space as recommended > by Nam Cao and Julia Lawall I see 2 "v3" patches sent to the list, yet they are different. So I don't know which one is correct :( Please resend a v4 with the correct change. thanks, greg k-h