From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF8ACC4332F for ; Thu, 20 Oct 2022 15:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229779AbiJTPFn (ORCPT ); Thu, 20 Oct 2022 11:05:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiJTPFk (ORCPT ); Thu, 20 Oct 2022 11:05:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E97D2E318A for ; Thu, 20 Oct 2022 08:05:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8630461BAA for ; Thu, 20 Oct 2022 15:05:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D86BC433C1; Thu, 20 Oct 2022 15:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666278335; bh=kvXoX4ijYxSANkduYlYoFnTVUFQxEl6TiWfaboeuW5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OJf7hTdmOGwP/n8wMK6FrwqmUPkKjfhdkAyJIt2/KThiuUVWGbpGFkcHIDZV/S6kp Rp4hN6JXGV7vMGk72rPZC1jDUYT/uz2WFvORESfuCOxeNXMh+lXM7dMyxiK32xjmof rH7388WBQ5oiXkuCGC7Duf+JCcaxdlOE/a7CQTcQ= Date: Thu, 20 Oct 2022 17:05:32 +0200 From: Greg KH To: Deepak R Varma Cc: Julia Lawall , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: Re: [PATCH v4 2/2] staging: most: dim2: correct misleading struct type name Message-ID: References: <6b772a1ac06ae3b0d63e198e7238c1590b14703a.1666208065.git.drv@mailo.com> <404cc67c-efd6-4a70-c3ca-7958db21bcb@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 05:04:52PM +0200, Greg KH wrote: > On Thu, Oct 20, 2022 at 06:26:12PM +0530, Deepak R Varma wrote: > > On Thu, Oct 20, 2022 at 02:06:41PM +0200, Julia Lawall wrote: > > > > > > > > > On Thu, 20 Oct 2022, Deepak R Varma wrote: > > > > > > > On Thu, Oct 20, 2022 at 02:00:29AM +0530, Deepak R Varma wrote: > > > > > On Wed, Oct 19, 2022 at 10:08:53PM +0200, Julia Lawall wrote: > > > > > > > > > > > > > > > > > > On Thu, 20 Oct 2022, Deepak R Varma wrote: > > > > > > > > > > > > > Correct misleading struct type name dim_ch_state_t to dim_ch_state > > > > > > > since this not a typedef but a normal structure declaration. > > > > > > > > > > > > > > Suggested-by: Julia Lawall > > > > > > > Signed-off-by: Deepak R Varma > > > > > > > --- > > > > > > > > > > > > > > Changes in v4: > > > > > > > 1. Correct patch subject and log message. Use struct type name instead of > > > > > > > variable name for the change description. Feedback from julia.lawall@inria.fr > > > > > > > > > > > > > > Changes in v3: > > > > > > > 1. Patch introduced in the patch set > > > > > > > > > > > > > > drivers/staging/most/dim2/dim2.c | 2 +- > > > > > > > drivers/staging/most/dim2/hal.c | 4 ++-- > > > > > > > drivers/staging/most/dim2/hal.h | 6 +++--- > > > > > > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c > > > > > > > index 4c1f27898a29..a69a61a69283 100644 > > > > > > > --- a/drivers/staging/most/dim2/dim2.c > > > > > > > +++ b/drivers/staging/most/dim2/dim2.c > > > > > > > @@ -161,7 +161,7 @@ static int try_start_dim_transfer(struct hdm_channel *hdm_ch) > > > > > > > struct list_head *head = &hdm_ch->pending_list; > > > > > > > struct mbo *mbo; > > > > > > > unsigned long flags; > > > > > > > - struct dim_ch_state_t st; > > > > > > > + struct dim_ch_state st; > > > > > > > > > > > > Is there another use in service_done_flag? > > > > > > > > > > Hi, > > > > > I did not understand your question fully. This is from a different function > > > > > try_start_dim_transfer where the variable st is used down the line in the > > > > > execution. This time the channel state is retrieved by calling > > > > > dim_get_channel_state function. The state is simply computed and set. Should I > > > > > improve this as well? > > > > > > > > > > If you are asking something different, could you please elaborate? > > > > > > > > Hi Julia, > > > > Can you please review and comment on my response? > > > > > > In my kernel there is an occurrence of the type name in service_done_flag. > > > But I have the mainline, not Greg's staging tree, so there could be some > > > differences. > > > > > > When I do git grep dim_ch_state_t, I get two occurrences in > > > drivers/staging/most/dim2/dim2.c > > > > Okay. Still unclear. Following snip is what I see in my local staging-testing branch. > > > > > > drv@debian:~/git/kernels/staging$ git grep dim_ch_state_t > > drivers/staging/most/dim2/dim2.c: struct dim_ch_state_t st; > > drivers/staging/most/dim2/dim2.c: struct dim_ch_state_t st; > > drivers/staging/most/dim2/hal.c:struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, > > drivers/staging/most/dim2/hal.c: struct dim_ch_state_t *state_ptr) > > drivers/staging/most/dim2/hal.h:struct dim_ch_state_t { > > drivers/staging/most/dim2/hal.h:struct dim_ch_state_t *dim_get_channel_state(struct dim_channel *ch, > > drivers/staging/most/dim2/hal.h: struct dim_ch_state_t *state_ptr); > > drv@debian:~/git/kernels/staging$ > > > > > > Does that help? > > Not at all, as you did not test with your change applied: > > CC [M] drivers/gpu/drm/vmwgfx/vmwgfx_drv.o > drivers/staging/most/dim2/dim2.c: In function ‘service_done_flag’: > drivers/staging/most/dim2/dim2.c:262:31: error: storage size of ‘st’ isn’t known > 262 | struct dim_ch_state_t st; > | ^~ > drivers/staging/most/dim2/dim2.c:262:31: error: unused variable ‘st’ [-Werror=unused-variable] > > :( > Ah, that was because I rejected patch 1/2 here. So this one will not work as-is, my fault. Please fix up and resend only this one if you still want to see it applied. thanks, greg k-h