From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mm-commits@vger.kernel.org, masahiroy@kernel.org,
gregkh@linuxfoundation.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array
Date: Thu, 20 Oct 2022 16:46:01 -0600 [thread overview]
Message-ID: <Y1HPqdBbv83VqCvp@zx2c4.com> (raw)
In-Reply-To: <Y1G+7e7l5dpHhCyP@smile.fi.intel.com>
On Fri, Oct 21, 2022 at 12:34:37AM +0300, Andy Shevchenko wrote:
> On Thu, Oct 20, 2022 at 01:17:33PM -0700, Linus Torvalds wrote:
> > On Thu, Oct 20, 2022 at 12:39 PM Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
>
> ...
>
> > And in some cases the differences are enormous:
> >
> > - drivers/net/wireless/ralink/rt2x00/rt2800lib.c generates a 220kB diff
> >
> > which seems to be due to entirely different inlining decisions or
> > something, and the differences are so enormous that I didn't even
> > start looking at the cause.
>
> This one is what we start the epopee from. I think Jason handled it in his last
> patch against this certain driver.
Right, and Kale is taking it for 6.1, because it fixes existing breakage
on ARM. But it's not broken on x86 with -funsigned-char.
Jason
next prev parent reply other threads:[~2022-10-20 22:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221020000356.177CDC433C1@smtp.kernel.org>
2022-10-20 9:43 ` + kbuild-treat-char-as-always-unsigned.patch added to mm-nonmm-unstable branch Alexey Dobriyan
2022-10-20 9:49 ` [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array Alexey Dobriyan
2022-10-20 9:56 ` [PATCH -mm] -funsigned-char, namei: delete cast in lookup_one_common() Alexey Dobriyan
2022-10-20 16:28 ` [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array Jason A. Donenfeld
2022-10-20 17:14 ` Linus Torvalds
2022-10-20 17:33 ` Jason A. Donenfeld
2022-10-20 17:42 ` Linus Torvalds
2022-10-20 18:57 ` Kees Cook
2022-10-20 19:39 ` Linus Torvalds
2022-10-20 20:17 ` Linus Torvalds
2022-10-20 21:34 ` Andy Shevchenko
2022-10-20 22:46 ` Jason A. Donenfeld [this message]
2022-10-21 6:48 ` Greg KH
2022-10-21 7:24 ` Jason A. Donenfeld
2022-10-21 7:36 ` Greg KH
2022-10-26 1:50 ` Jason A. Donenfeld
2022-10-26 12:58 ` Jason A. Donenfeld
2022-10-26 13:17 ` Andy Shevchenko
2022-11-02 17:17 ` [cocci] " Julia Lawall
2022-11-03 0:08 ` Jason A. Donenfeld
2022-11-03 6:31 ` Julia Lawall
2022-11-03 12:45 ` Julia Lawall
2022-11-03 12:47 ` Jason A. Donenfeld
2022-11-03 12:57 ` Julia Lawall
2022-11-03 14:07 ` Jason A. Donenfeld
2022-10-24 15:44 ` Jason A. Donenfeld
2022-10-21 5:59 ` Alexey Dobriyan
2022-10-21 17:11 ` Linus Torvalds
2022-10-21 17:23 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1HPqdBbv83VqCvp@zx2c4.com \
--to=jason@zx2c4.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox