From: Ming Lei <ming.lei@redhat.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@lst.de, axboe@kernel.dk, damien.lemoal@wdc.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH -next] block: fix memory leak for elevator on add_disk failure
Date: Fri, 21 Oct 2022 11:47:24 +0800 [thread overview]
Message-ID: <Y1IWTOO1RUIOZJQN@T590> (raw)
In-Reply-To: <20221021033950.3913764-1-yukuai1@huaweicloud.com>
On Fri, Oct 21, 2022 at 11:39:50AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> The default elevator is allocated in the begining of device_add_disk(),
> however, it's not freed in the following error path.
>
> Fixes: 737eb78e82d5 ("block: Delay default elevator initialization")
Originally elevator can be teardown in disk release, or queue release
earlier time, so the fixes tag should be:
Fixes: 50e34d78815e ("block: disable the elevator int del_gendisk")
Thanks,
Ming
next prev parent reply other threads:[~2022-10-21 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 3:39 [PATCH -next] block: fix memory leak for elevator on add_disk failure Yu Kuai
2022-10-21 3:47 ` Ming Lei [this message]
2022-10-22 1:54 ` Yu Kuai
2022-10-21 13:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1IWTOO1RUIOZJQN@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox