Re: [PATCH v1 3/6] spi: pxa2xx: Remove no more needed PCI ID table

Andy Shevchenko
2022-10-21T11:16:39Z

On Fri, Oct 21, 2022 at 11:59:20AM +0100, Mark Brown wrote:
> On Fri, Oct 21, 2022 at 01:51:47PM +0300, Andy Shevchenko wrote:
> > On Fri, Oct 21, 2022 at 11:42:31AM +0100, Mark Brown wrote:
>
> > > > That's exactly what I'm talking about when said "named resource check".
>
> > > Like I say a property can come from any firmware interface.
>
> > But I'm talking about resource (not a property) as IO memory. It doesn't come
> > via firmware at all. Have you had a chance to look into the v4?
>
> On DT based systems resources can be named by the firmware, I don't know
> if that's possible with ACPI but as the name suggests the driver gets
> used on PXA systems too.

And how is it related to DT if the enumeration happens via platform driver
code? As for PXA this is all comes via board files:

$ git grep -n -w '"pxa2xx-spi"'
Documentation/spi/pxa2xx.rst:66: .name = "pxa2xx-spi", /* MUST BE THIS VALUE, so device match driver */
arch/arm/mach-pxa/devices.c:1082: pd = platform_device_alloc("pxa2xx-spi", id);
arch/arm/mach-pxa/icontrol.c:127: .name = "pxa2xx-spi",
arch/arm/mach-pxa/icontrol.c:135: .name = "pxa2xx-spi",
drivers/mfd/intel-lpss.c:123: .name = "pxa2xx-spi",
drivers/spi/spi-pxa2xx-pci.c:298: pi.name = "pxa2xx-spi";
drivers/spi/spi-pxa2xx.c:1765: .name = "pxa2xx-spi",

In the current code and after my patch series the priority is that
the driver data from the spi-pxa2xx.c is the first. So, if compatible
(which is by fact the only "marvell,mmp2-ssp") has named resources
that exactly the same as LPSS for MFD, nothing will change the driver
behaviour.

For the ACPI there is no names for the resources so far.

--
With Best Regards,
Andy Shevchenko