Re: [PATCH v1 3/6] spi: pxa2xx: Remove no more needed PCI ID table

Mark Brown
2022-10-20T16:58:50Z

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On Thu, Oct 20, 2022 at 07:42:09PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 20, 2022 at 05:25:15PM +0100, Mark Brown wrote:

> > That's true currently since you're matching based on ACPI ID and then
> > have the lookup done with the ID information in the acpi_device_id table
> > but IIRC the patch was replacing that with some device property stuff.

> But that one also based on the IDs, it's not assigned without real IDs of
> the devices on the certain platforms. I don't see how it's different in
> this sense.

The driver won't even match and therefore load if it doesn't have a
lookup for the device with the current code, the type code comes from
the match. If it has to go querying a device property then the driver
can load but end up with a device property it hasn't ever heard of and
end up misbehaving as a result.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]