Re: [PATCH v3 5/6] staging: vt6655: refactor long lines of code in the rest of the file

Tanju Brunostar
2022-10-22T09:17:58Z

On Sat, Oct 22, 2022 at 9:17 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Oct 22, 2022 at 07:06:11AM +0000, Tanjuate Brunostar wrote:
> > fix checkpatch errors by refactoring long lines of code in the rest of
> > the file
> >
> > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
> > ---
> > drivers/staging/vt6655/rxtx.c | 105 ++++++++++++++++++++++------------
> > 1 file changed, 67 insertions(+), 38 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> > index 951d4172e9f2..572be45cdbeb 100644
> > --- a/drivers/staging/vt6655/rxtx.c
> > +++ b/drivers/staging/vt6655/rxtx.c
> > @@ -1105,44 +1105,60 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
> > if (byFBOption == AUTO_FB_NONE) {
> > if (bRTS) {/* RTS_need */
> > pvRrvTime = (void *)(pbyTxBufferAddr + wTxBufSize);
> > - pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts));
> > - pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
> > + pMICHDR = (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize +
> > + sizeof(struct vnt_rrv_time_rts));
> > + pvRTS = (void *)(pbyTxBufferAddr + wTxBufSize +
> > + sizeof(struct vnt_rrv_time_rts) + cbMICHDR);
>
> Casting to void * is very odd. Try working on fixing up that mess
> first...
>
> thanks,
>
> greg k-h
OK