From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Deepak R Varma <drv@mailo.com>
Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: remove commented debug printk messages
Date: Sun, 23 Oct 2022 20:35:47 +0700 [thread overview]
Message-ID: <Y1VDM2kWIi1I5dqI@debian.me> (raw)
In-Reply-To: <Y1L0FiKvrM9jjZG9@debian-BULLSEYE-live-builder-AMD64>
[-- Attachment #1: Type: text/plain, Size: 3114 bytes --]
On Sat, Oct 22, 2022 at 01:03:42AM +0530, Deepak R Varma wrote:
> diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
> index e04fc666d218..6bef419e8ad0 100644
> --- a/drivers/staging/wlan-ng/p80211netdev.c
> +++ b/drivers/staging/wlan-ng/p80211netdev.c
> @@ -881,55 +881,42 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> wlandev->rx.mgmt++;
> switch (fstype) {
> case WLAN_FSTYPE_ASSOCREQ:
> - /* printk("assocreq"); */
> wlandev->rx.assocreq++;
> break;
> case WLAN_FSTYPE_ASSOCRESP:
> - /* printk("assocresp"); */
> wlandev->rx.assocresp++;
> break;
> case WLAN_FSTYPE_REASSOCREQ:
> - /* printk("reassocreq"); */
> wlandev->rx.reassocreq++;
> break;
> case WLAN_FSTYPE_REASSOCRESP:
> - /* printk("reassocresp"); */
> wlandev->rx.reassocresp++;
> break;
> case WLAN_FSTYPE_PROBEREQ:
> - /* printk("probereq"); */
> wlandev->rx.probereq++;
> break;
> case WLAN_FSTYPE_PROBERESP:
> - /* printk("proberesp"); */
> wlandev->rx.proberesp++;
> break;
> case WLAN_FSTYPE_BEACON:
> - /* printk("beacon"); */
> wlandev->rx.beacon++;
> break;
> case WLAN_FSTYPE_ATIM:
> - /* printk("atim"); */
> wlandev->rx.atim++;
> break;
> case WLAN_FSTYPE_DISASSOC:
> - /* printk("disassoc"); */
> wlandev->rx.disassoc++;
> break;
> case WLAN_FSTYPE_AUTHEN:
> - /* printk("authen"); */
> wlandev->rx.authen++;
> break;
> case WLAN_FSTYPE_DEAUTHEN:
> - /* printk("deauthen"); */
> wlandev->rx.deauthen++;
> break;
> default:
> - /* printk("unknown"); */
> wlandev->rx.mgmt_unknown++;
> break;
> }
> - /* printk("\n"); */
> drop = 2;
> break;
>
> @@ -943,35 +930,27 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> wlandev->rx.ctl++;
> switch (fstype) {
> case WLAN_FSTYPE_PSPOLL:
> - /* printk("pspoll"); */
> wlandev->rx.pspoll++;
> break;
> case WLAN_FSTYPE_RTS:
> - /* printk("rts"); */
> wlandev->rx.rts++;
> break;
> case WLAN_FSTYPE_CTS:
> - /* printk("cts"); */
> wlandev->rx.cts++;
> break;
> case WLAN_FSTYPE_ACK:
> - /* printk("ack"); */
> wlandev->rx.ack++;
> break;
> case WLAN_FSTYPE_CFEND:
> - /* printk("cfend"); */
> wlandev->rx.cfend++;
> break;
> case WLAN_FSTYPE_CFENDCFACK:
> - /* printk("cfendcfack"); */
> wlandev->rx.cfendcfack++;
> break;
> default:
> - /* printk("unknown"); */
> wlandev->rx.ctl_unknown++;
> break;
> }
> - /* printk("\n"); */
> drop = 2;
> break;
>
> @@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> wlandev->rx.cfack_cfpoll++;
> break;
> default:
> - /* printk("unknown"); */
> wlandev->rx.data_unknown++;
> break;
> }
Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead?
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-10-23 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 19:33 [PATCH v2] staging: wlan-ng: remove commented debug printk messages Deepak R Varma
2022-10-23 13:35 ` Bagas Sanjaya [this message]
2022-10-21 22:40 ` Deepak R Varma
2022-10-24 3:10 ` Bagas Sanjaya
2022-10-23 14:13 ` Greg KH
2022-10-24 3:08 ` Bagas Sanjaya
2022-10-24 4:08 ` Greg KH
2022-10-24 9:29 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1VDM2kWIi1I5dqI@debian.me \
--to=bagasdotme@gmail.com \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox