From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: mingo@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [rft, PATCH v1 4/4] kernel.h: Split out ARRAY_SZIE()
Date: Mon, 24 Oct 2022 19:05:18 +0300 [thread overview]
Message-ID: <Y1a3vpiy8RBGfbsI@smile.fi.intel.com> (raw)
In-Reply-To: <Y1ay8k75fegxTcuG@x99>
On Mon, Oct 24, 2022 at 06:44:50PM +0300, Alexey Dobriyan wrote:
> > include/linux/array_size.h | 13 +++++++++++++
>
> All of this is pessimisation unless you're removing
>
> +#include <linux/array_size.h>
>
> from kernel.h which you aren't doing.
>
> container_of.h is just as silly.
>
> kernel.h might need _some_ cleanup (like panic and tainted stuff) which
> is rarely used but ARRAY_SIZE()?
Are you suggesting to slow down compilation with inclusion of tons of unneeded
stuff in the zillions of drivers?
Or you are talking that we need to abandon most of the headers and combine
everything into kernel.h? I think this is what is silly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-24 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 15:44 [rft, PATCH v1 4/4] kernel.h: Split out ARRAY_SZIE() Alexey Dobriyan
2022-10-24 16:05 ` Andy Shevchenko [this message]
2022-10-24 16:06 ` Andy Shevchenko
2022-10-24 18:14 ` Alexey Dobriyan
2022-10-25 8:20 ` Andy Shevchenko
2022-10-29 10:05 ` Alexey Dobriyan
2022-10-30 21:52 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2022-10-24 13:24 [rft, PATCH v1 1/4] kernel.h: Move READ/WRITE definitions to <linux/types.h> Andy Shevchenko
2022-10-24 13:24 ` [rft, PATCH v1 4/4] kernel.h: Split out ARRAY_SZIE() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1a3vpiy8RBGfbsI@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox