Re: [PATCH 8/8] mm/slub, percpu: correct the calculation of early percpu allocation size

Baoquan He
2022-11-07T04:37:09Z

On 11/06/22 at 09:56pm, Vlastimil Babka wrote:
> On 10/24/22 10:14, Baoquan He wrote:
> > SLUB allocator relies on percpu allocator to initialize its ->cpu_slab
> > during early boot. For that, the dynamic chunk of percpu which serves
> > the early allocation need be large enough to satisfy the kmalloc
> > creation.
> >
> > However, the current BUILD_BUG_ON() in alloc_kmem_cache_cpus() doesn't
> > consider the kmalloc array with NR_KMALLOC_TYPES length. Fix that
> > with correct calculation.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: Christoph Lameter <cl@linux.com>
> > Cc: Pekka Enberg <penberg@kernel.org>
> > Cc: David Rientjes <rientjes@google.com>
> > Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Roman Gushchin <roman.gushchin@linux.dev>
> > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> > ---
> > mm/slub.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> As only slub is touched and there's no prerequsities in the previous
> patches, I took this to the slab tree, branch
> slab/for-6.2/cleanups

Yes, it only changes slub code. Thanks for taking it.

I will resend v2 with the left 7 percpu only patches with update.