Re: [PATCH 0/8] Cleanup and optimization patches for percpu

Dennis Zhou
2022-10-24T18:30:21Z

Hello,

On Mon, Oct 24, 2022 at 04:14:27PM +0800, Baoquan He wrote:
> These were found out when reading percpu code, and queued in my local
> branch for long time. Send them out for reviewing.
>
> Baoquan He (8):
> mm/percpu: remove unused pcpu_map_extend_chunks
> mm/percpu: use list_first_entry_or_null in pcpu_reclaim_populated()
> mm/percpu: Update the code comment when creating new chunk
> mm/percpu: add comment to state the empty populated pages accounting
> mm/percpu: replace the goto with break
> mm/percpu.c: remove the lcm code since block size is fixed at page
> size
> mm/percpu: remove unused PERCPU_DYNAMIC_EARLY_SLOTS
> mm/slub, percpu: correct the calculation of early percpu allocation
> size
>
> include/linux/percpu.h | 7 +++----
> mm/percpu.c | 44 +++++++++++++++++-------------------------
> mm/slub.c | 3 ++-
> 3 files changed, 23 insertions(+), 31 deletions(-)
>
> --
> 2.34.1
>
>

Thanks for the clean ups. The empty page accounting is more subtle than
I remember.

Andrew, I think for these cleanups it'd be easiest for you to pick these
up.

Thanks,
Dennis