From: Jason Gunthorpe <jgg@nvidia.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: zyjzyj2000@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Bob Pearson <rpearsonhpe@gmail.com>
Subject: Re: [PATCH for-next v3 2/2] RDMA/rxe: Fix mr leak in RESPST_ERR_RNR
Date: Mon, 24 Oct 2022 14:13:46 -0300 [thread overview]
Message-ID: <Y1bHygLEu6VjXIzI@nvidia.com> (raw)
In-Reply-To: <20221024052049.20577-1-lizhijian@fujitsu.com>
On Mon, Oct 24, 2022 at 01:20:49PM +0800, Li Zhijian wrote:
> rxe_recheck_mr() will increase mr's ref_cnt, so we should call rxe_put(mr)
> to drop mr's ref_cnt in RESPST_ERR_RNR to avoid below warning:
> [ 633.447883] WARNING: CPU: 0 PID: 4156 at drivers/infiniband/sw/rxe/rxe_pool.c:259 __rxe_cleanup+0x1df/0x240 [rdma_rxe]
> ...
> [ 633.509482] Call Trace:
> [ 633.510246] <TASK>
> [ 633.510962] rxe_dereg_mr+0x4c/0x60 [rdma_rxe]
> [ 633.512123] ib_dereg_mr_user+0xa8/0x200 [ib_core]
> [ 633.513444] ib_mr_pool_destroy+0x77/0xb0 [ib_core]
> [ 633.514763] nvme_rdma_destroy_queue_ib+0x89/0x240 [nvme_rdma]
> [ 633.516230] nvme_rdma_free_queue+0x40/0x50 [nvme_rdma]
> [ 633.517577] nvme_rdma_teardown_io_queues.part.0+0xc3/0x120 [nvme_rdma]
> [ 633.519204] nvme_rdma_error_recovery_work+0x4d/0xf0 [nvme_rdma]
> [ 633.520695] process_one_work+0x582/0xa40
> [ 633.522987] ? pwq_dec_nr_in_flight+0x100/0x100
> [ 633.524227] ? rwlock_bug.part.0+0x60/0x60
> [ 633.525372] worker_thread+0x2a9/0x700
> [ 633.526437] ? process_one_work+0xa40/0xa40
> [ 633.527589] kthread+0x168/0x1a0
> [ 633.528518] ? kthread_complete_and_exit+0x20/0x20
> [ 633.529792] ret_from_fork+0x22/0x30
>
> CC: Bob Pearson <rpearsonhpe@gmail.com>
> Fixes: 8a1a0be894da ("RDMA/rxe: Replace mr by rkey in responder resources")
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> V2: remove mr testing
> ---
> drivers/infiniband/sw/rxe/rxe_resp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Sigh, please try to avoid sending patches in a way that causes
patchworks to become confused. I updated things to remove the if as in
this v2.
Jason
next prev parent reply other threads:[~2022-10-24 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 3:31 [PATCH for-next v3 1/2] RDMA/rxe: Remove unnecessary mr testing Li Zhijian
2022-10-24 5:20 ` [PATCH for-next v3 2/2] RDMA/rxe: Fix mr leak in RESPST_ERR_RNR Li Zhijian
2022-10-24 11:59 ` Leon Romanovsky
2022-10-24 14:15 ` Bob Pearson
2022-10-24 17:13 ` Jason Gunthorpe [this message]
2022-10-25 1:05 ` Li Zhijian
2022-10-24 14:10 ` [PATCH for-next v3 1/2] RDMA/rxe: Remove unnecessary mr testing Bob Pearson
2022-10-24 17:16 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1bHygLEu6VjXIzI@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox