Re: [PATCH v1] zram: add size class equals check into recompression

Aleksey Romanov
2022-10-25T09:54:20Z

On Tue, Oct 25, 2022 at 11:04:40AM +0900, Sergey Senozhatsky wrote:
> On (22/10/25 10:53), Sergey Senozhatsky wrote:
> > > +unsigned int zs_get_class_size(struct zs_pool *pool, unsigned int size)
> > > +{
> > > + struct size_class *class = pool->size_class[get_size_class_index(size)];
> > > +
> > > + return class->size;
> > > +}
> > > +EXPORT_SYMBOL_GPL(zs_get_class_size);
> >
> > I'll kindly ask for v2. This conflicts with configurable zspage order
> > patch set which I posted last night. get_size_class_index() now takes
> > the pool parameter.
>
> Oh, apparently Andrew already has a fixup patch for this.

Hi! Thanks for the quick response.

Do I need to submit v2 with a fix for >=? Also, I forgot to
correct the comment on the zs_get_class_size() function:

> * Return: the size (in bytes) of the zsmalloc &size_class into which
> * the object with specified size will be inserted.

... or already inserted.

--
Thank you,
Alexey