From: Sabrina Dubroca <sd@queasysnail.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Eric Dumazet <edumazet@google.com>,
syzbot <syzbot+1e9af9185d8850e2c2fa@syzkaller.appspotmail.com>,
davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, steffen.klassert@secunet.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [v3 PATCH] af_key: Fix send_acquire race with pfkey_register
Date: Wed, 26 Oct 2022 15:38:23 +0200 [thread overview]
Message-ID: <Y1k4T/rgRz4rkvcl@hog> (raw)
In-Reply-To: <Y1d8+FdfgtVCaTDS@gondor.apana.org.au>
2022-10-25, 14:06:48 +0800, Herbert Xu wrote:
> On Mon, Oct 24, 2022 at 09:20:00AM +0200, Sabrina Dubroca wrote:
> > 2022-10-24, 14:06:12 +0800, Herbert Xu wrote:
> > > @@ -1697,11 +1699,11 @@ static int pfkey_register(struct sock *sk, struct sk_buff *skb, const struct sad
> > > pfk->registered |= (1<<hdr->sadb_msg_satype);
> > > }
> > >
> > > - mutex_lock(&pfkey_mutex);
> > > + spin_lock_bh(&pfkey_alg_lock);
> > > xfrm_probe_algs();
> >
> > I don't think we can do that:
> >
> > void xfrm_probe_algs(void)
> > {
> > int i, status;
> >
> > BUG_ON(in_softirq());
>
> Indeed. I was also wrong in stating that this bug was created by
> namespaces. This race has always existed since this code was first
> added.
>
> ---8<---
> The function pfkey_send_acquire may race with pfkey_register
> (which could even be in a different name space). This may result
> in a buffer overrun.
>
> Allocating the maximum amount of memory that could be used prevents
> this.
>
> Reported-by: syzbot+1e9af9185d8850e2c2fa@syzkaller.appspotmail.com
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
LGTM, thanks.
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
--
Sabrina
next prev parent reply other threads:[~2022-10-26 13:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 2:37 [syzbot] kernel BUG in warn_crc32c_csum_combine syzbot
2022-10-24 2:49 ` Eric Dumazet
2022-10-24 5:01 ` Herbert Xu
2022-10-24 5:10 ` [PATCH] af_key: Fix send_acquire race with pfkey_register Herbert Xu
2022-10-24 5:21 ` Eric Dumazet
2022-10-24 6:06 ` [v2 PATCH] " Herbert Xu
2022-10-24 6:31 ` Eric Dumazet
2022-10-25 5:46 ` Herbert Xu
2022-10-24 7:20 ` Sabrina Dubroca
2022-10-25 6:06 ` [v3 " Herbert Xu
2022-10-26 13:38 ` Sabrina Dubroca [this message]
2022-10-27 3:42 ` Herbert Xu
2022-10-27 3:45 ` Eric Dumazet
2022-10-27 3:55 ` Herbert Xu
2022-10-28 11:26 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1k4T/rgRz4rkvcl@hog \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=syzbot+1e9af9185d8850e2c2fa@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox