From: Mark Brown <broonie@kernel.org>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
"Derek Fang" <derek.fang@realtek.com>,
kernel@collabora.com,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 2/4] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies
Date: Wed, 26 Oct 2022 13:49:46 +0100 [thread overview]
Message-ID: <Y1ks6n7wCfhArza/@sirena.org.uk> (raw)
In-Reply-To: <CAGXv+5HJo5x2ieOegmv5vkfh+rTevdR_fri-7PeK+Gd+GXVjNw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On Tue, Oct 25, 2022 at 01:12:49PM -0700, Chen-Yu Tsai wrote:
> On Mon, Oct 24, 2022 at 3:01 PM Nícolas F. R. A. Prado
> > The rt5682s codec can have two supplies: AVDD and MICVDD. They are
> Neither does the datasheet specify the ordering of AVDD, DBVDD, and
> LDO1_IN for power sequencing, just that three should be toggled together.
> Should we model these? Or wait until some design actually splits these?
Yes, the driver for a chip should be a driver for the chip not for some
specific board.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-26 12:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 22:00 [PATCH v2 0/4] Add missing dt-binding properties to rt5682(s) Nícolas F. R. A. Prado
2022-10-24 22:00 ` [PATCH v2 1/4] ASoC: dt-bindings: realtek,rt5682s: Add #sound-dai-cells Nícolas F. R. A. Prado
2022-10-25 10:06 ` AngeloGioacchino Del Regno
2022-10-25 19:57 ` Chen-Yu Tsai
2022-10-24 22:00 ` [PATCH v2 2/4] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-10-25 10:06 ` AngeloGioacchino Del Regno
2022-10-27 14:23 ` Nícolas F. R. A. Prado
2022-10-28 21:12 ` Nícolas F. R. A. Prado
2022-10-25 12:26 ` Krzysztof Kozlowski
2022-10-25 20:12 ` [PATCH v2 2/4] ASoC: dt-bindings: realtek, rt5682s: " Chen-Yu Tsai
2022-10-26 12:49 ` Mark Brown [this message]
2022-10-27 14:36 ` Nícolas F. R. A. Prado
2022-10-27 14:41 ` Mark Brown
2022-10-27 17:48 ` Chen-Yu Tsai
2022-10-27 18:11 ` Chen-Yu Tsai
2022-10-27 19:20 ` Nícolas F. R. A. Prado
2022-10-27 20:42 ` Chen-Yu Tsai
2022-10-24 22:00 ` [PATCH v2 3/4] ASoC: dt-bindings: rt5682: Set sound-dai-cells to 1 Nícolas F. R. A. Prado
2022-10-25 10:07 ` AngeloGioacchino Del Regno
2022-10-25 12:26 ` Krzysztof Kozlowski
2022-10-25 20:13 ` Chen-Yu Tsai
2022-10-24 22:00 ` [PATCH v2 4/4] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
2022-10-25 12:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1ks6n7wCfhArza/@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=derek.fang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox