public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Reka Norman <rekanorman@chromium.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] xhci: Apply XHCI_RESET_TO_DEFAULT quirk to ADL-N
Date: Fri, 28 Oct 2022 08:11:33 +0200	[thread overview]
Message-ID: <Y1tyldAD/nDIoL3d@kroah.com> (raw)
In-Reply-To: <CAEmPcwtZt0RoksByW0OnkNsBiPJ-wHqzR9nuZEwAn3d2m=fyOA@mail.gmail.com>

On Fri, Oct 28, 2022 at 10:56:56AM +1100, Reka Norman wrote:
> On Thu, Oct 27, 2022 at 5:11 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Oct 27, 2022 at 04:34:07PM +1100, Reka Norman wrote:
> > > ADL-N systems have the same issue as ADL-P, where a large boot firmware
> > > delay is seen if USB ports are left in U3 at shutdown. So apply the
> > > XHCI_RESET_TO_DEFAULT quirk to ADL-N as well.
> > >
> > > This patch depends on "xhci: Add quirk to reset host back to default
> > > state at shutdown".
> >
> > What is the git commit id of that change?
> 
> It hasn't been merged in mainline yet, only in the xhci tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?id=feb0b04b09c82589af65c84398b7d3fefaa7b7ac&head=for-usb-linus
> Should I add the commit id from there? Or add the lore link?

This is in linux-next already as 34cd2db408d5 ("xhci: Add quirk to reset
host back to default state at shutdown") right?

Please use that.

> > And is this needed in stable kernels?  If so, how far back?
> 
> Sorry, I'm not sure how to answer that properly.
> It looks like most ADL-N support was added starting from 5.16.
> The issue it fixes is a ~20s boot delay in the specific case of booting from S5.
> It probably makes sense for it to go wherever the ADL-P patch goes.

Then properly mark it with that information.

thanks,

greg k-h

  reply	other threads:[~2022-10-28  6:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  5:34 [PATCH] xhci: Apply XHCI_RESET_TO_DEFAULT quirk to ADL-N Reka Norman
2022-10-27  6:12 ` Greg Kroah-Hartman
2022-10-27 23:56   ` Reka Norman
2022-10-28  6:11     ` Greg Kroah-Hartman [this message]
2022-10-31  3:54       ` Reka Norman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1tyldAD/nDIoL3d@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=rekanorman@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox