From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, shuah@kernel.org,
patches@kernelci.org, lkft-triage@lists.linaro.org,
pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com,
sudipm.mukherjee@gmail.com, srw@sladewatkins.net
Subject: Re: [PATCH 5.15 00/79] 5.15.76-rc1 review
Date: Fri, 28 Oct 2022 12:42:21 +0200 [thread overview]
Message-ID: <Y1uyDV3i2heNmyne@kroah.com> (raw)
In-Reply-To: <3624500e-8e07-ac95-8b15-2843a3c9d7c4@roeck-us.net>
On Thu, Oct 27, 2022 at 11:18:42AM -0700, Guenter Roeck wrote:
> On 10/27/22 09:54, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.76 release.
> > There are 79 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> > Anything received after that time might be too late.
> >
> Building arm64:allmodconfig ... failed
> --------------
> Error log:
> In file included from drivers/cpufreq/tegra194-cpufreq.c:10:
> drivers/cpufreq/tegra194-cpufreq.c:282:25: error: 'tegra194_cpufreq_of_match' undeclared here (not in a function); did you mean 'tegra194_cpufreq_data'?
> 282 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/module.h:244:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
> 244 | extern typeof(name) __mod_##type##__##name##_device_table \
> | ^~~~
> include/linux/module.h:244:21: error: conflicting types for '__mod_of__tegra194_cpufreq_of_match_device_table'; have 'const struct of_device_id[2]'
> 244 | extern typeof(name) __mod_##type##__##name##_device_table \
> | ^~~~~~
> drivers/cpufreq/tegra194-cpufreq.c:417:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
> 417 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
> | ^~~~~~~~~~~~~~~~~~~
> include/linux/module.h:244:21: note: previous declaration of '__mod_of__tegra194_cpufreq_of_match_device_table' with type 'int'
> 244 | extern typeof(name) __mod_##type##__##name##_device_table \
> | ^~~~~~
> drivers/cpufreq/tegra194-cpufreq.c:282:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
> 282 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
> | ^~~~~~~~~~~~~~~~~~~
> make[3]: [scripts/Makefile.build:289: drivers/cpufreq/tegra194-cpufreq.o] Error 1 (ignored)
> ERROR: modpost: missing MODULE_LICENSE() in drivers/cpufreq/tegra194-cpufreq.o
> make[2]: [scripts/Makefile.modpost:133: modules-only.symvers] Error 1 (ignored)
>
> I don't know what exactly happened, but commit b281adc68db8 ("cpufreq:
> tegra194: Fix module loading") introduces a second MODULE_DEVICE_TABLE
> at the wrong location, causing the build failure.
Ah, the "Fixes:" tag was wrong in the original commit in Linus's tree.
It should have said:
Fixes: 0839ed1fd7ac ("cpufreq: tegra194: add soc data to support multiple soc")
which removed the existing MODULE_DEVICE_TABLE() entry.
So only kernels newer than 5.19 need this. I'll go drop it from the
5.10.y and 5.15.y queues, thanks!
greg k-h
next prev parent reply other threads:[~2022-10-28 10:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 16:54 [PATCH 5.15 00/79] 5.15.76-rc1 review Greg Kroah-Hartman
2022-10-27 16:55 ` [PATCH 5.15 02/79] arm64/mm: Consolidate TCR_EL1 fields Greg Kroah-Hartman
2022-10-27 18:18 ` [PATCH 5.15 00/79] 5.15.76-rc1 review Guenter Roeck
2022-10-28 10:42 ` Greg Kroah-Hartman [this message]
2022-10-28 3:46 ` Bagas Sanjaya
2022-10-28 9:58 ` Naresh Kamboju
2022-10-28 10:40 ` Sudip Mukherjee (Codethink)
2022-10-28 10:44 ` Sudip Mukherjee
2022-10-28 11:58 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1uyDV3i2heNmyne@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=patches@kernelci.org \
--cc=patches@lists.linux.dev \
--cc=pavel@denx.de \
--cc=shuah@kernel.org \
--cc=srw@sladewatkins.net \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox