Re: linux-next: Signed-off-by missing for commit in the rdma-fixes tree

Joe Perches
2018-03-08T16:39:45Z

On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote:
> On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> >
> > is missing a Signed-off-by from its author.
>
> Thanks Stephen,
>
> May I suggest to the checkpatch maintainers that checkpack should look
> for this too?

No such commit in current -hext
$ git status HEAD
HEAD detached at next-20180308

checkpatch doesn't try to match email sender to sign-off
as the email sender doesn't have to sign-off on a patch.

It currently does:

if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {
ERROR("MISSING_SIGN_OFF",
"Missing Signed-off-by: line(s)\n");
}