Re: [PATCH 01/11] dt-bindings: usb: tegra-xudc: Add Tegra234 XUSB controller support

Wayne Chang
2022-11-03T10:36:52Z

On 10/26/22 07:24, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, Oct 24, 2022 at 03:41:18PM +0800, Wayne Chang wrote:
>> Extend the Tegra XUSB controller device tree binding with Tegra234
>> support.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> ---
>> .../bindings/usb/nvidia,tegra-xudc.yaml | 24 ++++++++++++-------
>> 1 file changed, 16 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
>> index fd6e7c81426e..517fb692f199 100644
>> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
>> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
>> @@ -22,6 +22,7 @@ properties:
>> - nvidia,tegra210-xudc # For Tegra210
>> - nvidia,tegra186-xudc # For Tegra186
>> - nvidia,tegra194-xudc # For Tegra194
>> + - nvidia,tegra234-xudc # For Tegra234
>>
>> reg:
>> minItems: 2
>> @@ -90,21 +91,27 @@ properties:
>>
>> phys:
>> minItems: 1
>> + maxItems: 8
>> description:
>> Must contain an entry for each entry in phy-names.
>> See ../phy/phy-bindings.txt for details.
>>
>> phy-names:
>> minItems: 1
>> + maxItems: 8
>> items:
>> - - const: usb2-0
>> - - const: usb2-1
>> - - const: usb2-2
>> - - const: usb2-3
>> - - const: usb3-0
>> - - const: usb3-1
>> - - const: usb3-2
>> - - const: usb3-3
>> + anyOf:
>> + - const: usb2-0
>> + - const: usb2-1
>> + - const: usb2-2
>> + - const: usb2-3
>> + - const: usb3-0
>> + - const: usb3-1
>> + - const: usb3-2
>> + - const: usb3-3
>
> items:
> pattern: '^usb[23]-[0-3]$'
>
> And an explanation why you need any random order. If it is just
> different for Tegra234, then you need an if/then schema for this.

Thanks for the review.
We need to pick up one or more for the corresponding phys of the USB ports.
It should be a common settings among all the chips.
Adding anyOf here for the reason above and passing the dtb check.

Please let me know If I have any misunderstanding here.

thanks,
Wayne.

>
>> +
>> + dma-coherent:
>> + type: boolean
>>
>> avddio-usb-supply:
>> description: PCIe/USB3 analog logic power supply. Must supply 1.05 V.
>> @@ -153,6 +160,7 @@ allOf:
>> enum:
>> - nvidia,tegra186-xudc
>> - nvidia,tegra194-xudc
>> + - nvidia,tegra234-xudc
>> then:
>> properties:
>> reg:
>> --
>> 2.25.1
>>
>>