From: Deepak R Varma <drv@mailo.com>
To: outreachy@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: wlan-ng: Use flexible-array for one / zero-length arrays
Date: Fri, 28 Oct 2022 18:08:13 +0530 [thread overview]
Message-ID: <Y1vNNSSWK1EkcohT@ubunlion> (raw)
Flexible-array member should be used instead of one or zero member to
meet the need for having a dynamically sized trailing elements in a
structure. Refer to links [1] and [2] for detailed guidance on this
suggestion.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Issue identified using coccicheck.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/staging/wlan-ng/p80211mgmt.h | 8 ++++----
drivers/staging/wlan-ng/p80211types.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h
index 1ef30d3f3159..d6fe52de2c8f 100644
--- a/drivers/staging/wlan-ng/p80211mgmt.h
+++ b/drivers/staging/wlan-ng/p80211mgmt.h
@@ -229,14 +229,14 @@ struct wlan_ie {
struct wlan_ie_ssid {
u8 eid;
u8 len;
- u8 ssid[1]; /* may be zero, ptrs may overlap */
+ u8 ssid[]; /* may be zero, ptrs may overlap */
} __packed;
/*-- Supported Rates -----------------------------*/
struct wlan_ie_supp_rates {
u8 eid;
u8 len;
- u8 rates[1]; /* had better be at LEAST one! */
+ u8 rates[]; /* had better be at LEAST one! */
} __packed;
/*-- FH Parameter Set ----------------------------*/
@@ -274,7 +274,7 @@ struct wlan_ie_tim {
u8 dtim_cnt;
u8 dtim_period;
u8 bitmap_ctl;
- u8 virt_bm[1];
+ u8 virt_bm[];
} __packed;
/*-- IBSS Parameter Set ---------------------------*/
@@ -288,7 +288,7 @@ struct wlan_ie_ibss_parms {
struct wlan_ie_challenge {
u8 eid;
u8 len;
- u8 challenge[1];
+ u8 challenge[];
} __packed;
/*-------------------------------------------------*/
diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h
index 6486612a8f31..b2ffd09881b0 100644
--- a/drivers/staging/wlan-ng/p80211types.h
+++ b/drivers/staging/wlan-ng/p80211types.h
@@ -234,7 +234,7 @@ struct p80211pstr32 {
/* MAC address array */
struct p80211macarray {
u32 cnt;
- u8 data[1][MAXLEN_PSTR6];
+ u8 data[][MAXLEN_PSTR6];
} __packed;
/* prototype template */
--
2.34.1
next reply other threads:[~2022-10-28 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 12:38 Deepak R Varma [this message]
2022-10-28 13:33 ` [PATCH] staging: wlan-ng: Use flexible-array for one / zero-length arrays Dan Carpenter
2022-10-28 13:41 ` Deepak R Varma
2022-10-28 14:14 ` Dan Carpenter
2022-10-28 14:36 ` Dan Carpenter
2022-10-28 14:44 ` Deepak R Varma
2022-10-28 14:48 ` Dan Carpenter
2022-11-01 13:56 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vNNSSWK1EkcohT@ubunlion \
--to=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox