Re: [PATCH 04/15] pcmcia: synclink_cs: remove dead paranoia_check, warn for missing line

наб
2022-10-27T11:32:01Z

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Thu, Oct 27, 2022 at 07:53:34AM +0300, Andy Shevchenko wrote:
> On Thu, Oct 27, 2022 at 1:42 AM наб <nabijaczleweli@nabijaczleweli.xyz> wrote:
> > in that case
> > ("invalid line #%d.")
>
> Please, respect English grammar and punctuation, in particular don't
> forget the trailing periods.
>
> > + if (!info) {
> > + printk(KERN_WARNING "%s(%d):mgslpc_open: "
> > + "no device for line #%d.\n",
> > + __FILE__, __LINE__, line);
>
> Even though the old code uses this awkward style for messages, please
> follow the modern one, i.e.
>
> pr_warn("mgslpc_open: no device for line #%d.\n", line);

Both applied for v2.

наб

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]