From: Dan Carpenter <dan.carpenter@oracle.com>
To: Deepak R Varma <drv@mailo.com>
Cc: outreachy@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: Use flexible-array for one / zero-length arrays
Date: Fri, 28 Oct 2022 17:48:11 +0300 [thread overview]
Message-ID: <Y1vrq5tP3XslI5Go@kadam> (raw)
In-Reply-To: <Y1vq5QdBn1oQUqij@ubunlion>
On Fri, Oct 28, 2022 at 08:14:53PM +0530, Deepak R Varma wrote:
> Also, there are a few function declarations that I do not think are used in the
> code anywhere.
> File: drivers/staging/wlan-ng/p80211mgmt.h
> Line number : 500 through 519
>
> Can you please comment if it is safe to remove these functions and include this
> clean-up as well in the proposed patch?
Always feel free to delete code that is not used.
(But send the patch tomorrow and as part of a patchset).
regards,
dan carpenter
next prev parent reply other threads:[~2022-10-28 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 12:38 [PATCH] staging: wlan-ng: Use flexible-array for one / zero-length arrays Deepak R Varma
2022-10-28 13:33 ` Dan Carpenter
2022-10-28 13:41 ` Deepak R Varma
2022-10-28 14:14 ` Dan Carpenter
2022-10-28 14:36 ` Dan Carpenter
2022-10-28 14:44 ` Deepak R Varma
2022-10-28 14:48 ` Dan Carpenter [this message]
2022-11-01 13:56 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vrq5tP3XslI5Go@kadam \
--to=dan.carpenter@oracle.com \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox