From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A11C433FE for ; Thu, 10 Nov 2022 17:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbiKJRsg (ORCPT ); Thu, 10 Nov 2022 12:48:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbiKJRsd (ORCPT ); Thu, 10 Nov 2022 12:48:33 -0500 Received: from mail-4018.proton.ch (mail-4018.proton.ch [185.70.40.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F5C4B7E0 for ; Thu, 10 Nov 2022 09:48:31 -0800 (PST) Date: Thu, 10 Nov 2022 17:48:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skothe.de; s=protonmail; t=1668102508; x=1668361708; bh=jREI8kgsv+Ac+JI7HxX8UFFBUU8DxYtXvRHvFerAf7o=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=H5jzGUa4HQyLu6QpNeuoqlXwRtZhPI6Op0YxmjDEp0m0QXC+CUuZ2BSTFVc9GMTCH vL+p0tKEmArLC9N08ioCGN4/xqGjdf8g0Fy8qyfNcCbcRZ75LetG31jX8MaINqntfw awav3RCKcm/hmZVp3XENnqHNkIm3LAeMD0aLB/OZADNBDA2NSzCdP4LzC7Z5XZkCO8 FSEjnszKgMaY+h5LKlSOiwoy6K6CXzOebdWVoT5y+xAMVpt36IHsdVLtLgyBHXWrJU meF6vRQl+yJVILkYezM5hxecW7ITpaTCvo6PbVbp6NNmQdegECl4n7p07WcGDNo276 aDKgEscg8EX7w== To: Saravana Kannan From: Steffen Kothe Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts: dev-needs.sh: Enforce bash usage Message-ID: In-Reply-To: References: <20221109170341.36785-1-steffen.kothe@skothe.de> Feedback-ID: 55345914:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Wed, Nov 09, 2022 at 02:58:15PM -0800 schrieb Saravana Kannan: > On Wed, Nov 9, 2022 at 9:04 AM Steffen Kothe wr= ote: > > > > Calling the script from a system which does not invoke bash > > by default causes a return with a syntax error like: > > > > ./dev-needs.sh: 6: Syntax error: "(" unexpected > > > > /bin/sh invokes on most distributions a symbolic link to a > > default shell like dash (Debian) or bash (Ubuntu). > > > > Since the script depends on bash syntax, enforce the same by > > default to prevent syntax errors caused by wrong shell type usage. > > I wrote this so that it can run on an Android target that runs toybox. > Sadly toybox doesn't like have /bin/bash. This will break my use case. > So I'll have to Nak this. Ok, I see. > I'm open to other ideas though as I'd like to this to work in as many > cases as possible. Should we just add a wrapper that has /bin/bash and > then sources this file? I mean, we could leave at least a warning on top above the first function via a simple echo. Sth. like: =09echo "Warning: $0 is only tested for following shell variants =09 [toybox, bash]. Other shells might be not following the =09 specific syntax of this script." =09echo "Shell is: $(readlink /bin/sh)" I would prevent to add another wrapper to it, because its fairly easy to cp this file to a target. An embedded system with a pure POSIX compliant shell will never be compatible to this kind of syntax. What do you think about a more describing approach of the error instead of handling it with some weird logic and wrapping? Cheers, =09skothe > Also looks like multiple #! lines aren't supported by bash, so we > can't add multiple lines either. > > -Saravana > > > > > Signed-off-by: Steffen Kothe > > --- > > scripts/dev-needs.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/dev-needs.sh b/scripts/dev-needs.sh > > index 454cc304fb448..46537859727bc 100755 > > --- a/scripts/dev-needs.sh > > +++ b/scripts/dev-needs.sh > > @@ -1,4 +1,4 @@ > > -#! /bin/sh > > +#! /bin/bash > > # SPDX-License-Identifier: GPL-2.0 > > # Copyright (c) 2020, Google LLC. All rights reserved. > > # Author: Saravana Kannan > > -- > > 2.30.2 > > > > -- Cheers, =09Steffen