From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF39C4332F for ; Thu, 10 Nov 2022 13:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231273AbiKJN4w (ORCPT ); Thu, 10 Nov 2022 08:56:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbiKJN4t (ORCPT ); Thu, 10 Nov 2022 08:56:49 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0AA7701A4; Thu, 10 Nov 2022 05:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668088609; x=1699624609; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3Kynfksy1jqiHQeRo7Tb/8wLk+wUbBqH9WM9nmjcUsQ=; b=I/5rM/HtoQwnsz+IaJ7jAa4qycdgObUcwfcNLdbE8NeIiIWqqwm1/yJ/ 71ZW4kJCu5j1pJutEh+WhAFTDmAFsodI283YGqIAV1FFstymhEVQEXFV5 Nl4DhB5JQxMbISlaujK87RCfgbp3tWNoiPmMumlRQ/TDtcqwTv7uXfIL0 n/RsPtoeHTsdejBF/MlxHjLVcbQ+f7DBXnkLJpVplHVfRoRH6q36o73TX 6KGbZAZLq0b+V1esvk0KRkamm/WDqF5ceEAw9EvZzK3CBDnopPkpApdbz 6JzSUZwHx9eioGwUT0njFEd0S0S49KIsj37AmLWqc06gzWzudAnn1Orb2 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="294659737" X-IronPort-AV: E=Sophos;i="5.96,153,1665471600"; d="scan'208";a="294659737" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 05:56:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="742859975" X-IronPort-AV: E=Sophos;i="5.96,153,1665471600"; d="scan'208";a="742859975" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 10 Nov 2022 05:56:46 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ot82v-00A9wK-0V; Thu, 10 Nov 2022 15:56:45 +0200 Date: Thu, 10 Nov 2022 15:56:44 +0200 From: Andy Shevchenko To: Dmitry Torokhov Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v1 1/2] gpiolib: of: Prepare of_mm_gpiochip_add_data() for fwnode Message-ID: References: <20221109150734.38874-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2022 at 01:19:30PM -0800, Dmitry Torokhov wrote: > On Wed, Nov 09, 2022 at 05:07:33PM +0200, Andy Shevchenko wrote: ... > > - of_node_put(mm_gc->gc.of_node); > > - mm_gc->gc.of_node = of_node_get(np); > > + fwnode_handle_put(mm_gc->gc.fwnode); > > + mm_gc->gc.fwnode = fwnode_handle_get(fwnode); > > Can we reduce the patch to > > fwnode_handle_put(mm_gc->gc.fwnode); > mm_gc->gc.fwnode = fwnode_handle_get(of_fwnode_handle(np)); > > ? Sure. As Linus pointed out, it's anyway temporary. > I do not see a reason for converting the rest of invocations to fwnode > given that this is clearly an OF API. ...which should go away. -- With Best Regards, Andy Shevchenko