From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D2DC4332F for ; Thu, 10 Nov 2022 14:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbiKJOdk (ORCPT ); Thu, 10 Nov 2022 09:33:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbiKJOdf (ORCPT ); Thu, 10 Nov 2022 09:33:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 535E5F0F for ; Thu, 10 Nov 2022 06:33:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF27F618F7 for ; Thu, 10 Nov 2022 14:33:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02142C433C1; Thu, 10 Nov 2022 14:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668090811; bh=+rHJIUa3DRKlQrklPQi153v0vgi/mtpzdYW9aIbOaa4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYvHGydPUtMr6U9+8ypPRydeMyiPJGQ6rakj+r6k8Gx8fdAWdZBGFbQ2NyvB6AgCw z70QISOT/2m0DOL++qT67fVZ10wD1BeQGqG++IviOGO9bvovEltqXjL2IF3wPm2EF9 PVKFwDyNCjUYkLiXpNSw1+5wLyRW4vw+V5KWFZko= Date: Thu, 10 Nov 2022 15:33:28 +0100 From: Greg Kroah-Hartman To: Christophe Leroy Cc: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0 Message-ID: References: <20dd37b96bac0a72caef28e7462b32c93487a516.1665033909.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 01:25:14PM +0000, Christophe Leroy wrote: > Hi Greg, > > Le 06/10/2022 à 07:27, Christophe Leroy a écrit : > > NO_IRQ is used to check the return of irq_of_parse_and_map(). > > > > On some architecture NO_IRQ is 0, on other architectures it is -1. > > > > irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ. > > > > So use 0 instead of using NO_IRQ. > > > > Signed-off-by: Christophe Leroy > > Do you plan to apply this patch, or is any change required ? It is in my review queue, give me time to catch up... thanks, greg k-h