Re: [PATCH net] iavf: Do not restart Tx queues after reset task failure

Jacob Keller
2022-11-08T16:41:08Z

On 11/8/2022 2:25 AM, Ivan Vecera wrote:
> After commit aa626da947e9 ("iavf: Detach device during reset task")
> the device is detached during reset task and re-attached at its end.
> The problem occurs when reset task fails because Tx queues are
> restarted during device re-attach and this leads later to a crash.
>
> To resolve this issue properly close the net device in cause of
> failure in reset task to avoid restarting of tx queues at the end.
> Also replace the hacky manipulation with IFF_UP flag by device close
> that clears properly both IFF_UP and __LINK_STATE_START flags.
> In these case iavf_close() does not do anything because the adapter
> state is already __IAVF_DOWN.

Thanks for fixing this. I thought we'd removed the last such use of
incorrect IFF_UP munging in 7d59706dbef8 ("Revert "iavf: Fix deadlock
occurrence during resetting VF interface""), but apparently we had
missed one...

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>