From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8702FC433FE for ; Thu, 10 Nov 2022 18:22:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231907AbiKJSWD (ORCPT ); Thu, 10 Nov 2022 13:22:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232048AbiKJSVo (ORCPT ); Thu, 10 Nov 2022 13:21:44 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38C344D5CB for ; Thu, 10 Nov 2022 10:20:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7D6B61DDD for ; Thu, 10 Nov 2022 18:20:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8164C433D7; Thu, 10 Nov 2022 18:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668104458; bh=wi/r7g7EKYmj4XnMc8eJm6KXDr90O2MOBuJsu80cQn8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ST1siAQh+LwA7aBwQGJZCYbqQig+upyNgLyEFIIKUnU3bm+FEuo36UtsF5+MnB1As rB6SXkKJ6TOY9QeRI5gHyCFxl3OlOGW8FqU+BclHVImCAh7QlN6JtPaox54gYjrv0B KfT4oci4lrDsEBtz9wLkS611YVaJ4kcbeu8I4GWc= Date: Thu, 10 Nov 2022 19:20:55 +0100 From: Greg KH To: Tejun Heo Cc: Chengming Zhou , linux-kernel@vger.kernel.org, syzbot+2fdf66e68f5f882c1074@syzkaller.appspotmail.com Subject: Re: [PATCH] fs/kernfs: Fix lockdep warning in kernfs_active() Message-ID: References: <0000000000002473fd05eca7540a@google.com> <20221109120415.55759-1-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2022 at 08:11:34AM -1000, Tejun Heo wrote: > On Thu, Nov 10, 2022 at 07:00:52PM +0100, Greg KH wrote: > > Shouldn't: > > https://lore.kernel.org/r/Y0SwqBsZ9BMmZv6x@slm.duckdns.org fix this > > instead? > > The difference is around whether the id based lookup can see hidden files or > not. But yeah, it makes more sense to hide it. So your patch should not have been applied to my tree? And I should take this one instead? confused, greg k-h