public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ashok Raj <ashok_raj@linux.intel.com>
To: Xin Li <xin3.li@intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
	seanjc@google.com, pbonzini@redhat.com, kevin.tian@intel.com,
	Ashok Raj <ashok.raj@intel.com>
Subject: Re: [RESEND PATCH 1/6] x86/traps: let common_interrupt() handle IRQ_MOVE_CLEANUP_VECTOR
Date: Thu, 10 Nov 2022 18:59:08 +0000	[thread overview]
Message-ID: <Y21J/CehGK7a4Lva@araj-dh-work> (raw)
In-Reply-To: <20221110061545.1531-2-xin3.li@intel.com>

On Wed, Nov 09, 2022 at 10:15:40PM -0800, Xin Li wrote:
> From: "H. Peter Anvin (Intel)" <hpa@zytor.com>
> 
> IRQ_MOVE_CLEANUP_VECTOR is the only one of the system IRQ vectors that
> is *below* FIRST_SYSTEM_VECTOR. It is a slow path, so just push it
> into common_interrupt() just before the spurios interrupt handling.

nit: 
s/spurios/spurious


> 
> Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> Signed-off-by: Xin Li <xin3.li@intel.com>
> ---
>  arch/x86/kernel/irq.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 766ffe3ba313..7e125fff45ab 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -248,6 +248,10 @@ DEFINE_IDTENTRY_IRQ(common_interrupt)
>  	desc = __this_cpu_read(vector_irq[vector]);
>  	if (likely(!IS_ERR_OR_NULL(desc))) {
>  		handle_irq(desc, regs);
> +#ifdef CONFIG_SMP
> +	} else if (vector == IRQ_MOVE_CLEANUP_VECTOR) {
> +		sysvec_irq_move_cleanup(regs);
> +#endif
>  	} else {
>  		ack_APIC_irq();
>  
> -- 
> 2.34.1
> 

  reply	other threads:[~2022-11-10 19:10 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  6:15 [RESEND PATCH 0/6] x86/traps,VMX: implement software based NMI/IRQ dispatch for VMX NMI/IRQ reinjection Xin Li
2022-11-10  6:15 ` [RESEND PATCH 1/6] x86/traps: let common_interrupt() handle IRQ_MOVE_CLEANUP_VECTOR Xin Li
2022-11-10 18:59   ` Ashok Raj [this message]
2022-11-10 22:09     ` Li, Xin3
2022-11-10  6:15 ` [RESEND PATCH 2/6] x86/traps: add a system interrupt table for system interrupt dispatch Xin Li
2022-11-10  8:56   ` Peter Zijlstra
2022-11-10 19:55     ` Li, Xin3
2022-11-10 20:36       ` Li, Xin3
2022-11-10 21:12         ` Nathan Chancellor
2022-11-10 23:00           ` Li, Xin3
2022-11-11  0:08             ` Nathan Chancellor
2022-11-11  3:03               ` Li, Xin3
2022-11-11  8:58         ` Peter Zijlstra
2022-11-11  1:12       ` Tian, Kevin
2022-11-11  3:54         ` Li, Xin3
2022-11-11  8:55       ` Peter Zijlstra
2022-11-11 22:07       ` H. Peter Anvin
2022-11-12  9:47         ` Peter Zijlstra
2022-11-10  6:15 ` [RESEND PATCH 3/6] x86/traps: add install_system_interrupt_handler() Xin Li
2022-11-10  6:15 ` [RESEND PATCH 4/6] x86/traps: add external_interrupt() to dispatch external interrupts Xin Li
2022-11-10 16:24   ` Sean Christopherson
2022-11-10 18:02     ` Li, Xin3
2022-11-10 20:10       ` Sean Christopherson
2022-11-10  6:15 ` [RESEND PATCH 5/6] KVM: x86/VMX: add kvm_vmx_reinject_nmi_irq() for NMI/IRQ reinjection Xin Li
2022-11-10  9:03   ` Peter Zijlstra
2022-11-10 20:53     ` Li, Xin3
2022-11-11  9:15       ` Peter Zijlstra
2022-11-11 12:04         ` Paolo Bonzini
2022-11-11 12:19           ` Peter Zijlstra
2022-11-11 12:48             ` Paolo Bonzini
2022-11-11 14:23               ` Peter Zijlstra
2022-11-11 16:35                 ` Andrew Cooper
2022-11-11 22:22                   ` H. Peter Anvin
2022-11-12  0:08                     ` Andrew Cooper
2022-11-11 18:06                 ` Li, Xin3
2022-11-11 19:33                   ` Peter Zijlstra
2022-11-12  6:35                     ` Li, Xin3
2022-11-14  4:39                     ` Li, Xin3
2022-11-14  9:08                       ` Peter Zijlstra
2022-11-15  7:50                         ` Li, Xin3
2022-11-15  9:17                           ` Peter Zijlstra
2022-11-17  3:37                             ` Li, Xin3
2022-11-17 15:51                               ` Sean Christopherson
2022-11-18  0:05                                 ` Li, Xin3
2022-11-22 13:00                                   ` Li, Xin3
2022-11-22 20:52                                     ` Sean Christopherson
2022-11-23  8:31                                       ` Li, Xin3
2022-11-23 20:42                                         ` Sean Christopherson
2022-11-24  3:40                                           ` Li, Xin3
2022-11-28 16:26                                             ` Sean Christopherson
2022-11-24  9:46                                           ` Peter Zijlstra
2022-11-28 19:05                                             ` Sean Christopherson
2022-11-23  9:16                                       ` Peter Zijlstra
2022-11-23 19:18                                         ` Sean Christopherson
2022-11-11 22:15                 ` H. Peter Anvin
2022-11-10  6:15 ` [RESEND PATCH 6/6] x86/traps: remove unused NMI entry exc_nmi_noist() Xin Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y21J/CehGK7a4Lva@araj-dh-work \
    --to=ashok_raj@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xin3.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox