Re: [PATCH bpf-next] selftests/bpf: Fix error undeclared identifier 'NF_NAT_MANIP_SRC'

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2284 bytes --]

> On 11/11, Rong Tao wrote:
> > From: Rong Tao <rongtao@cestc.cn>
> 
> > commit 472caa69183f("netfilter: nat: un-export nf_nat_used_tuple")
> > introduce NF_NAT_MANIP_SRC/DST enum in include/net/netfilter/nf_nat.h,
> > and commit b06b45e82b59("selftests/bpf: add tests for bpf_ct_set_nat_info
> > kfunc") use NF_NAT_MANIP_SRC/DST in test_bpf_nf.c. We copy enum
> > nf_nat_manip_type to test_bpf_nf.c fix this error.
> 
> > How to reproduce the error:
> 
> >      $ make -C tools/testing/selftests/bpf/
> >      ...
> >        CLNG-BPF [test_maps] test_bpf_nf.bpf.o
> >        error: use of undeclared identifier 'NF_NAT_MANIP_SRC'
> >              bpf_ct_set_nat_info(ct, &saddr, sport, NF_NAT_MANIP_SRC);
> >                                                             ^
> >        error: use of undeclared identifier 'NF_NAT_MANIP_DST'
> >              bpf_ct_set_nat_info(ct, &daddr, dport, NF_NAT_MANIP_DST);
> >                                                             ^
> >      2 errors generated.
> 
> $ grep NF_NAT_MANIP_SRC
> ./tools/testing/selftests/bpf/tools/include/vmlinux.h
>         NF_NAT_MANIP_SRC = 0,
> 
> Doesn't look like your kernel config compiles netfilter nat modules?

yes, in bpf kself-test config (tools/testing/selftests/bpf/config) nf_nat
is compiled as built-in. This issue occurs just if it is compiled as module.

Regards,
Lorenzo

> 
> > Link: https://lore.kernel.org/lkml/202210280447.STsT1gvq-lkp@intel.com/
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Rong Tao <rongtao@cestc.cn>
> > ---
> >   tools/testing/selftests/bpf/progs/test_bpf_nf.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> 
> > diff --git a/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > b/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > index 227e85e85dda..307ca166ff34 100644
> > --- a/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > +++ b/tools/testing/selftests/bpf/progs/test_bpf_nf.c
> > @@ -3,6 +3,11 @@
> >   #include <bpf/bpf_helpers.h>
> >   #include <bpf/bpf_endian.h>
> 
> > +enum nf_nat_manip_type {
> > +	NF_NAT_MANIP_SRC,
> > +	NF_NAT_MANIP_DST
> > +};
> > +
> >   #define EAFNOSUPPORT 97
> >   #define EPROTO 71
> >   #define ENONET 64
> > --
> > 2.31.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]