Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry

gregkh
2022-11-14T07:16:07Z

On Sun, Nov 13, 2022 at 12:48:40PM +0100, Borislav Petkov wrote:
> Replying to both with one mail because it still feels like there's a
> misunderstanding.
>
> On Sun, Nov 13, 2022 at 08:37:32AM +0100, gregkh@linuxfoundation.org wrote:
> > No, please do not force the driver to resolve a filename path in the
> > kernel.
>
> No, I don't mean to do any filename path resolving - all I suggest is to
> echo into sysfs the full filename instead of the number. I.e., this:
>
> for i in $(ls /lib/firmware/intel/ifs_0/*.scan);
> do
> echo $i /sys/devices/virtual/misc/intel_ifs_0/current_batch
> done

Sorry, yes, that is fine, I was objecting to the previous "write any
path/file to the sysfs entry and the kernel will parse it" that was
happening in the original series. A filename, without a path, that
always loads from the existing in-kernel firmware path locations is
fine.

thanks,

greg k-h