Re: [PATCH v2 06/14] x86/microcode/intel: Expose microcode_sanity_check()

Sohil Mehta
2022-11-09T03:04:07Z

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> IFS test image carries the same microcode header as regular Intel
> microcode blobs. Microcode blobs use header version of 1,
> whereas IFS test images will use header version of 2.
>
> microcode_sanity_check() can be used by IFS driver to perform
> sanity check of the IFS test images too.
>
> Refactor header version as a parameter, move it to cpu/intel.c
> and expose this function. Qualify the function name with intel.
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

...

> + if (data_size + MC_HEADER_SIZE > total_size) {
> + if (print_err)
> + pr_err("Error: invalid/unknown microcode update format.\n");
> + return -EINVAL;
> + }
> +

The wording for the "bad file size" print seems to have changed during
the move. Any specific reason for this?

> - if (data_size + MC_HEADER_SIZE > total_size) {
> - if (print_err)
> - pr_err("Error: bad microcode data file size.\n");
> - return -EINVAL;
> - }
> -

Other than that,

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>