Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry

gregkh
2022-11-13T07:37:43Z

On Sat, Nov 12, 2022 at 06:33:58PM +0000, Luck, Tony wrote:
>
> > Dunno - sounds silly to me. Means one needs to go and look up which
> > files are there and echo those batch numbers into sysfs and so on.
> >
> > What I would do is make it real trivial for the user so that latter can
> > simply do:
> >
> > for f in $(ls /lib/firmware/intel/ifs_0/*.scan);
> > do
> > echo $f > /sys/devices/virtual/misc/intel_ifs_0/test_file
> > done
> >
> > and simply supply the full filename.
>
> We tried the full file name in an earlier version. GregKH was unimpressed. But that was when we were trying to overload the meaning of the “reload” file.
>
> Is it different now?

No, please do not force the driver to resolve a filename path in the
kernel.