* [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0
@ 2022-10-31 22:25 Jonathan Neuschäfer
2022-10-31 23:03 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Neuschäfer @ 2022-10-31 22:25 UTC (permalink / raw)
To: devicetree, linux-spi
Cc: Jonathan Neuschäfer, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Mark Brown,
Rob Herring, Krzysztof Kozlowski, openbmc, linux-kernel
The node name for flash memories has been standardized to "flash@...".
Fix the example in nuvoton,npcm-fiu.txt accordingly.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
index c63ce4cc0a80f..fb38e96d395fb 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
+++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
@@ -51,7 +51,7 @@ fiu3: spi@c00000000 {
clocks = <&clk NPCM7XX_CLK_AHB>;
pinctrl-names = "default";
pinctrl-0 = <&spi3_pins>;
- spi-nor@0 {
+ flash@0 {
...
};
};
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0
2022-10-31 22:25 [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0 Jonathan Neuschäfer
@ 2022-10-31 23:03 ` Mark Brown
2022-10-31 23:30 ` Jonathan Neuschäfer
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2022-10-31 23:03 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: devicetree, linux-spi, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Rob Herring,
Krzysztof Kozlowski, openbmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> The node name for flash memories has been standardized to "flash@...".
> Fix the example in nuvoton,npcm-fiu.txt accordingly.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0
2022-10-31 23:03 ` Mark Brown
@ 2022-10-31 23:30 ` Jonathan Neuschäfer
2022-11-01 0:36 ` Jonathan Neuschäfer
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Neuschäfer @ 2022-10-31 23:30 UTC (permalink / raw)
To: Mark Brown
Cc: Jonathan Neuschäfer, devicetree, linux-spi, Avi Fishman,
Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen,
Benjamin Fair, Rob Herring, Krzysztof Kozlowski, openbmc,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > The node name for flash memories has been standardized to "flash@...".
> > Fix the example in nuvoton,npcm-fiu.txt accordingly.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Documentation/devicetree/bindings/spi/ has a wild mix of
- spi: <some vendor>:
- spi: dt-bindings:
- dt-bindings: spi:
"spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0
2022-10-31 23:30 ` Jonathan Neuschäfer
@ 2022-11-01 0:36 ` Jonathan Neuschäfer
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Neuschäfer @ 2022-11-01 0:36 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: Mark Brown, devicetree, linux-spi, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Rob Herring, Krzysztof Kozlowski, openbmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
On Tue, Nov 01, 2022 at 12:30:51AM +0100, Jonathan Neuschäfer wrote:
> On Mon, Oct 31, 2022 at 11:03:34PM +0000, Mark Brown wrote:
> > On Mon, Oct 31, 2022 at 11:25:59PM +0100, Jonathan Neuschäfer wrote:
> > > The node name for flash memories has been standardized to "flash@...".
> > > Fix the example in nuvoton,npcm-fiu.txt accordingly.
> >
> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
Ah sorry, I missed this line:
> > There's no need to resubmit to fix this alone.
>
> Documentation/devicetree/bindings/spi/ has a wild mix of
>
> - spi: <some vendor>:
> - spi: dt-bindings:
> - dt-bindings: spi:
>
>
> "spi: dt-bindings:" seems to win out slightly. I'll switch it to that for v2.
So, no v2.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-01 0:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-31 22:25 [PATCH] dt-bindings: spi: nuvoton,npcm-fiu: Change spi-nor@0 name to flash@0 Jonathan Neuschäfer
2022-10-31 23:03 ` Mark Brown
2022-10-31 23:30 ` Jonathan Neuschäfer
2022-11-01 0:36 ` Jonathan Neuschäfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox