From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DC7FA373D for ; Tue, 1 Nov 2022 10:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbiKAK1U (ORCPT ); Tue, 1 Nov 2022 06:27:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbiKAK1R (ORCPT ); Tue, 1 Nov 2022 06:27:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66639186DA for ; Tue, 1 Nov 2022 03:27:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 159A2B81B24 for ; Tue, 1 Nov 2022 10:27:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB71DC433C1; Tue, 1 Nov 2022 10:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667298433; bh=GmUuTDxUxCHcU9fP52IJK8r+2tkOY9kkmS196UJcsRY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SsdqcRzwdzFMXa/fNNqQhtJn2TYyCLPp4GRShc63wr6v0UAt0OzxeuJkKGcFhu9ZK 9EE2nVYeJk6EuEC6EMK1FLApRhj7l9E2G2m9OUaO4DqrCYsR+xutxwoFC3vtj5wTJm B0eckueUdIiMt1K2fl4fbukF9QHuUUHG3uD37hGwGpgGVlzpOAdkTOAzqP/FNYfx0y y8gCTOCwEHoQh8DbeUyjpNw04Or/C9pRy57ZL1agENHQ3L3ZqH9pbKLlQDTTpJR7aJ lzBoPFaWwI+VqPDvDOZoT2H0OeBs8TmASGvOG3lGs1sRTPzLhWUqNFl86IMrXPwSvV K5+gzVsDz6B2Q== Date: Tue, 1 Nov 2022 10:27:08 +0000 From: Lee Jones To: Paul Cercueil Cc: Nathan Chancellor , kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 28/28] mfd: intel-lpss: Remove #ifdef guards for PM related functions Message-ID: References: <20221023094852.8035-29-paul@crapouillou.net> <202210232035.D9ecuZtH-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Oct 2022, Paul Cercueil wrote: > > > Le lun. 31 oct. 2022 à 15:43:44 +0000, Lee Jones a écrit : > > On Mon, 31 Oct 2022, Paul Cercueil wrote: > > > > > Hi, > > > > > > Le lun. 31 oct. 2022 à 08:03:25 -0700, Nathan Chancellor > > > > > > a écrit : > > > > On Mon, Oct 31, 2022 at 02:59:37PM +0000, Lee Jones wrote: > > > > > On Sun, 23 Oct 2022, kernel test robot wrote: > > > > > > > > > > > Hi Paul, > > > > > > > > > > > > I love your patch! Yet something to improve: > > > > > > > > > > > > [auto build test ERROR on lee-mfd/for-mfd-next] > > > > > > [also build test ERROR on linus/master v6.1-rc1 > > > next-20221021] > > > > > > [If your patch is applied to the wrong git tree, kindly drop > > > us a > > > > > note. > > > > > > And when submitting patch, we suggest to use '--base' as > > > > > documented in > > > > > > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/mfd-Remove-ifdef-guards-for-PM-functions/20221023-175612 > > > > > > base: > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git > > > > > for-mfd-next > > > > > > patch link: > > > > > > > > https://lore.kernel.org/r/20221023094852.8035-29-paul%40crapouillou.net > > > > > > patch subject: [PATCH v3 28/28] mfd: intel-lpss: Remove > > > #ifdef > > > > > guards for PM related functions > > > > > > config: i386-randconfig-a013 > > > > > > compiler: clang version 14.0.6 > > > > > (https://github.com/llvm/llvm-project > > > > > f28c006a5895fc0e329fe15fead81e37457cb1d1) > > > > > > reproduce (this is a W=1 build): > > > > > > wget > > > > > > > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > > > > > -O ~/bin/make.cross > > > > > > chmod +x ~/bin/make.cross > > > > > > # https://github.com/intel-lab-lkp/linux/commit/873891d1ee1634da028bb74d0e7cfa5d77b2f157 > > > > > > git remote add linux-review > > > > > https://github.com/intel-lab-lkp/linux > > > > > > git fetch --no-tags linux-review > > > > > > > > Paul-Cercueil/mfd-Remove-ifdef-guards-for-PM-functions/20221023-175612 > > > > > > git checkout 873891d1ee1634da028bb74d0e7cfa5d77b2f157 > > > > > > # save the config file > > > > > > mkdir build_dir && cp config build_dir/.config > > > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang > > > > > make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash > > > drivers/mfd/ > > > > > > > > > > > > If you fix the issue, kindly add following tag where > > > applicable > > > > > > | Reported-by: kernel test robot > > > > > > > > > > > > All errors (new ones prefixed by >>): > > > > > > > > > > > > >> drivers/mfd/intel-lpss-pci.c:75:8: error: type specifier > > > > > missing, defaults to 'int' [-Werror,-Wimplicit-int] > > > > > > static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops); > > > > > > ~~~~~~ ^ > > > > > > >> drivers/mfd/intel-lpss-pci.c:75:26: error: a parameter > > > list > > > > > without types is only allowed in a function definition > > > > > > static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops); > > > > > > ^ > > > > > > 2 errors generated. > > > > > > > > > > Is this a valid error? > > > > > > > > Yes, because this change removes the definition of > > > INTEL_LPSS_PM_OPS in > > > > intel-lpss.h. > > > > > > The "static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops)" is dead code; > > > just > > > removing this line should be enough to make it work. > > > > > > I'll V2 when I find some time. > > > > Thanks. > > > > I'll put this set on hold for v2. > > If you think the other patches are OK you can merge them, and I'll just send > a V2 with this one patch. Okay, works for me. -- Lee Jones [李琼斯]