From: Wolfram Sang <wsa@kernel.org>
To: Angel Iglesias <ang.iglesiasg@gmail.com>
Cc: linux-iio@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Nuno Sá" <noname.nuno@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] i2c: core: Introduce i2c_client_get_device_id helper function
Date: Tue, 1 Nov 2022 14:09:32 +0100 [thread overview]
Message-ID: <Y2EajA8DU4WXLSfE@shikoro> (raw)
In-Reply-To: <aeac9f372ffe0013757e261229e6e23f76f2d8f9.1667151588.git.ang.iglesiasg@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On Sun, Oct 30, 2022 at 06:52:18PM +0100, Angel Iglesias wrote:
> Introduces new helper function to aid in .probe_new() refactors. In order
> to use existing i2c_get_device_id() on the probe callback, the device
> match table needs to be accessible in that function, which would require
> bigger refactors in some drivers using the deprecated .probe callback.
>
> This issue was discussed in more detail in the IIO mailing list.
>
> Link: https://lore.kernel.org/all/20221023132302.911644-11-u.kleine-koenig@pengutronix.de/
> Suggested-by: Nuno Sá <noname.nuno@gmail.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
Looks good to me!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-01 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 17:51 [RFC PATCH 0/2] i2c: core: Introduce i2c_client_get_device_id helper Angel Iglesias
2022-10-30 17:52 ` [RFC PATCH 1/2] i2c: core: Introduce i2c_client_get_device_id helper function Angel Iglesias
2022-11-01 13:09 ` Wolfram Sang [this message]
2022-11-01 14:54 ` Uwe Kleine-König
2022-11-01 23:53 ` Angel Iglesias
2022-10-30 17:53 ` [RFC PATCH 2/2] iio: pressure: bmp280: convert to i2c's .probe_new() Angel Iglesias
2022-11-01 21:52 ` Uwe Kleine-König
2022-11-02 0:16 ` Angel Iglesias
2022-11-05 14:54 ` Jonathan Cameron
2022-11-01 14:58 ` [RFC PATCH 0/2] i2c: core: Introduce i2c_client_get_device_id helper Andy Shevchenko
2022-11-05 14:56 ` Jonathan Cameron
2022-11-05 21:29 ` Wolfram Sang
2022-11-06 12:09 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2EajA8DU4WXLSfE@shikoro \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox