Re: [RFC PATCH 2/2] iio: pressure: bmp280: convert to i2c's .probe_new()

Uwe Kleine-König
2022-11-01T21:53:00Z

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

Hello,

On Sun, Oct 30, 2022 at 06:53:11PM +0100, Angel Iglesias wrote:
> Use i2c_client_get_device_id() to get the i2c_device_id* parameter in the
> .new_probe() callback.
>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> ---
> drivers/iio/pressure/bmp280-i2c.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-i2c.c
> index 0c27211f3ea0..20073b09b3e3 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -5,11 +5,11 @@
>
> #include "bmp280.h"
>
> -static int bmp280_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int bmp280_i2c_probe(struct i2c_client *client)
> {
> - struct regmap *regmap;
> + const struct i2c_device_id *id = i2c_client_get_device_id(client);
> const struct regmap_config *regmap_config;
> + struct regmap *regmap;
>
> switch (id->driver_data) {
> case BMP180_CHIP_ID:

What is the motivation for moving regmap? I thought reverse christmas
tree is only a thing in network code? I would have left the regmap
declaration where it is.

> @@ -65,7 +65,7 @@ static struct i2c_driver bmp280_i2c_driver = {
> .of_match_table = bmp280_of_i2c_match,
> .pm = pm_ptr(&bmp280_dev_pm_ops),
> },
> - .probe = bmp280_i2c_probe,
> + .probe_new = bmp280_i2c_probe,
> .id_table = bmp280_i2c_id,
> };
> module_i2c_driver(bmp280_i2c_driver);

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]