From: Johan Hovold <johan@kernel.org>
To: Shazad Hussain <quic_shazhuss@quicinc.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
andersson@kernel.org, bmasney@redhat.com,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref_clk
Date: Wed, 2 Nov 2022 10:26:13 +0100 [thread overview]
Message-ID: <Y2I3tekSAO42r0xR@hovoldconsulting.com> (raw)
In-Reply-To: <bb590bfb-07a4-97c1-e5c0-d00d840e2e11@quicinc.com>
On Wed, Nov 02, 2022 at 02:15:26PM +0530, Shazad Hussain wrote:
> On 11/2/2022 1:43 PM, Johan Hovold wrote:
> > Right, but if the PHYs really requires CX and it is not an ancestor of
> > the refclk then this should be described by the binding (and not be
> > hidden away in the clock driver).
> This makes sense, will be posting v2 post for the same.
> I assume this should use the Fixes tag then !
Yeah, I guess to you can add a fixes tag for the commits adding support
for sc8280xp to the UFS PHY binding and driver.
But please do check with the hardware documentation first so we get this
right this time.
I've already asked Bjorn to see what he can dig out as it is still not
clear how the two "card" refclocks (GCC_UFS_CARD_CLKREF_CLK and
GCC_UFS_1_CARD_CLKREF_CLK) are supposed to be used.
Johan
next prev parent reply other threads:[~2022-11-02 9:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 14:23 [PATCH v1] clk: qcom: gcc-sc8280xp: add cxo as parent for gcc_ufs_ref_clkref_clk Shazad Hussain
2022-10-31 11:22 ` Brian Masney
2022-11-01 18:23 ` Stephen Boyd
2022-11-02 7:16 ` Johan Hovold
2022-11-02 7:58 ` Shazad Hussain
2022-11-02 8:13 ` Johan Hovold
2022-11-02 8:45 ` Shazad Hussain
2022-11-02 9:26 ` Johan Hovold [this message]
2022-11-03 2:49 ` Bjorn Andersson
2022-11-03 9:06 ` Johan Hovold
2022-11-03 15:23 ` Bjorn Andersson
2022-11-04 9:29 ` Johan Hovold
2022-11-03 2:54 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2I3tekSAO42r0xR@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_shazhuss@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox