From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C79C433FE for ; Wed, 2 Nov 2022 07:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230337AbiKBH3F (ORCPT ); Wed, 2 Nov 2022 03:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiKBH3C (ORCPT ); Wed, 2 Nov 2022 03:29:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6C2A10E6 for ; Wed, 2 Nov 2022 00:29:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8BC81B82115 for ; Wed, 2 Nov 2022 07:29:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 363D4C433D6; Wed, 2 Nov 2022 07:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667374139; bh=PqmmqrMvPpwusmfzs25Ti0ixsJP9q/A+fj2LM+9egvc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XqrH3xDIeM0b5sTwegyRBlHHXq9ZtEE5eFDkazHzbdh+VJYTsUHUGWuiFOV07SRJO XSX0yoH0bFfVAhxo6P3KCMk15RvFuriHPS273ve2c4msaP/+qSV+auMJsJm8Eq8uiQ GNetBdjcjw27uJ0pUglzNLyR4GKhEdF6FIWc7jhA= Date: Wed, 2 Nov 2022 08:29:52 +0100 From: Greg Kroah-Hartman To: Deepak R Varma Cc: outreachy@lists.linux.dev, Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: r8188eu: remove unwanted variable implementation Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2022 at 01:48:18AM +0530, Deepak R Varma wrote: > Local variables intended as the function return value are > initialized but their value does not change during function > execution. The initial value assigned to the variable is simply > returned to the caller. This makes the variable declaration > unnecessary and the initial value can be directly returned. > > Following table lists the initial commits when the variables were first > introduced but have not been used since inception: > > Variable Function File Inception Commit > ret rtw_sta_flush r8188eu/core/rtw_ap.c [1] > ret amsdu_to_msdu r8188eu/core/rtw_recv.c [2] > ret rtw_p2p_set r8188eu/os_dep/ioctl_linux.c [3] > > [1] 'commit 9a7fe54ddc3a ("staging: r8188eu: Add source files for new driver - part 1")' > [2] 'commit 1cc18a22b96b ("staging: r8188eu: Add files for new driver - part 5")' > [3] 'commit a2c60d42d97c ("staging: r8188eu: Add files for new driver - part 16")' > > However, local variable pull of the function update_txdesc from file > r8188eu/hal/rtl8188eu_xmit.c was in use prior to introduction of > commit ID [4] 7bdedfef085bb65. The clean-up associated with this > commit left the variable pull redundant. > > [4] 'commit 7bdedfef085b ("staging: r8188eu: Remove mp, a.k.a. manufacturing process, code")' > > The patch is produced using the following coccicheck options: > COCCI=./scripts/coccinelle/misc/returnvar.cocci > M=driver/staging/r8188eu/ > MODE=patch > > Signed-off-by: Deepak R Varma > --- > > Changes in v2: > 1. Include reason for why the variable declarations are not useful. Suggested > by Julia Lawall Does not apply to my tree at all :( Please rebase and resubmit. thanks, greg k-h