From: 'Tejun Heo' <tj@kernel.org>
To: David Laight <David.Laight@aculab.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Martin Liska <mliska@suse.cz>, Josef Bacik <josef@toxicpanda.com>,
Jens Axboe <axboe@kernel.dk>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block/blk-iocost (gcc13): cast enum members to int in prints
Date: Wed, 2 Nov 2022 06:27:46 -1000 [thread overview]
Message-ID: <Y2Kaghnu/sPvl0+g@slm.duckdns.org> (raw)
In-Reply-To: <2b975ee3117e45aaa7882203cf9a4db8@AcuMS.aculab.com>
On Wed, Nov 02, 2022 at 08:35:34AM +0000, David Laight wrote:
> I think the enums have to be split.
> There will be other side effects of promoting the constants to 64bit
> that are much more difficult to detect than the warnings from printf.
idk, I think I can just add LLU to everything and it should be fine.
> I'm also not sure whether the type is even consistent for 32bit
> and 64bit builds.
> Casts are (sort of) horrid.
Yeah, I don't think casts are the solution either. Lemme add LLU to
everything and see how it works.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-11-02 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:45 [PATCH] block/blk-iocost (gcc13): cast enum members to int in prints Jiri Slaby (SUSE)
2022-10-31 12:24 ` Christoph Hellwig
2022-10-31 17:57 ` Tejun Heo
2022-11-01 5:46 ` Jiri Slaby
2022-11-01 16:46 ` Tejun Heo
2022-11-02 8:35 ` David Laight
2022-11-02 16:27 ` 'Tejun Heo' [this message]
2022-11-02 16:43 ` 'Tejun Heo'
2022-12-12 12:14 ` Jiri Slaby
2022-12-12 21:46 ` 'Tejun Heo'
2022-12-13 8:30 ` David Laight
2022-12-13 11:15 ` Jiri Slaby
2022-12-13 11:50 ` David Laight
2022-12-13 12:05 ` Jiri Slaby
2022-12-13 12:58 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Kaghnu/sPvl0+g@slm.duckdns.org \
--to=tj@kernel.org \
--cc=David.Laight@aculab.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@infradead.org \
--cc=jirislaby@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox