From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E1A5C4332F for ; Thu, 3 Nov 2022 00:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230320AbiKCASl (ORCPT ); Wed, 2 Nov 2022 20:18:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiKCASh (ORCPT ); Wed, 2 Nov 2022 20:18:37 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CEED65FE for ; Wed, 2 Nov 2022 17:18:37 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id q1so243812pgl.11 for ; Wed, 02 Nov 2022 17:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bCQtxRI6S1jaqGbru2XthNpEAYm8+HAaLC9FoyL3iBk=; b=ddOVPbUD4GyJ/5XxPS/mySuFr/TZqCDiPVo9GH5CMKvrTD9xTT6+UO4zrCBFKU6bEc h7iFaz1TwgLyS1lmNKCKyVvbfdE94I1MqYrGDZWD5xWse9iRG12oTRrFTSlnK7t+GhU6 zsh6zFAlY0V5ufRSJ9y427zXuXwsiNHsdAcp7mSBeiJ+eAublCFO2nYPLvbP9Ci4wLaR Kjr7sPZUB8dgqiJ9HRV1V8T013QNdf4icnegHPrhrCHIN6xAmB7ELa4AiEcQU/2cOeGv xMbntHQBIPIAMM7tiJ7/z3GmESEUn3GTQ1PVUOy/jlzkf6m7c4vCDZRacouaktiLfoiQ 8+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bCQtxRI6S1jaqGbru2XthNpEAYm8+HAaLC9FoyL3iBk=; b=umXtDhmonBs90gJQxoMN3MtN63UoG3U89RyVwiZvyZxqHWMWVrVQETqkISS7aIY2VQ NhikPEQlnw39O4zYQXtukfXYE6AWEKK6jSkg88x4pfIoiI5T3+RgDPtG94n53N9/t6wn sX6FSPnqz5NCRIBLoN2yp6laZIKkMzdWN04PkBXBNqsQjsh5moc4OS+uBjgflbiLbc82 S/lC7NGaAVYzLyB1nFY1EcbRQLMtpnnL0nhzN6uaWRE2VDWS8WSf1FGRZu0OY5tY+m63 cxHBph8JoN2ywek0vynUIkn480mU4DCik0IjHlbZ7MfJFwXy9IBcxZKoy0G7wfF+u4G5 ymsw== X-Gm-Message-State: ACrzQf0UV86K6iB7nHLtn+zIy4BHEtWzZvTk3QUK6DtCkUAPPOXSNurT 80a461QGMvqFlZotETQaHnAdqQ== X-Google-Smtp-Source: AMsMyM7/LM4Pq2WKGmQ3w010goQWJD+Neqa+YUNygZhB9ScSJlfXq7noZEoeP9p4lqaKOsr0L4qEQw== X-Received: by 2002:a63:6905:0:b0:43c:d4:eef4 with SMTP id e5-20020a636905000000b0043c00d4eef4mr23204378pgc.126.1667434716555; Wed, 02 Nov 2022 17:18:36 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id 4-20020a621404000000b0056c704abca7sm9011808pfu.220.2022.11.02.17.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 17:18:36 -0700 (PDT) Date: Thu, 3 Nov 2022 00:18:32 +0000 From: Sean Christopherson To: Vipin Sharma Cc: pbonzini@redhat.com, dmatlack@google.com, andrew.jones@linux.dev, wei.w.wang@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 3/7] KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi() Message-ID: References: <20221102232737.1351745-1-vipinsh@google.com> <20221102232737.1351745-4-vipinsh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221102232737.1351745-4-vipinsh@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2022, Vipin Sharma wrote: > atoi() doesn't detect errors. There is no way to know that a 0 return > is correct conversion or due to an error. > > Introduce atoi_paranoid() to detect errors and provide correct > conversion. Replace all atoi() calls with atoi_paranoid(). > > Signed-off-by: Vipin Sharma > Suggested-by: David Matlack > Suggested-by: Sean Christopherson > --- Reviewed-by: Sean Christopherson