Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p()

Andy Shevchenko
2022-11-03T18:59:52Z

On Fri, Nov 04, 2022 at 03:29:44AM +0900, Krzysztof Wilczyński wrote:

> > > > -
> > > > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> > > > - res = s->cb_dev->bus->resource[i];
> > > > -#else
> > > > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
> > > > #endif
> > > > +
> > > > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) {
> > > > if (!res)
> > > > continue;
> > >
> > > Doesn't this remove the proper iterator for X86? Even if that is the right
> > > thing to do, it needs an explict explanation.
> >
> > I dunno what was in 2010, but reading code now I have found no differences in
> > the logic on how resources are being iterated in these two pieces of code.
>
> This code is over a decade old (13 years old to be precise) and there was
> something odd between Bjorn's and Jesse's patches, as per:
>
> 89a74ecccd1f ("PCI: add pci_bus_for_each_resource(), remove direct bus->resource[] refs")
> cf26e8dc4194 ("pcmcia: do not autoadd root PCI bus resources")

Yeah, thanks for pointing out to the other patch from the same 2010 year.
It seems the code was completely identical that time, now it uses more
sophisticated way of getting bus resources, but it's kept the same for
the resources under PCI_BRIDGE_RESOURCE_NUM threshold.

> > But fine, I will add a line to a commit message about this change.
>
> I wouldn't, personally. The change you are proposing is self-explanatory
> and somewhat in-line with what is there already - unless I am also reading
> the current implementation wrong.

But it wouldn't be harmful either.

> That said, Dominik is the maintainer of PCMCIA driver, so his is the last
> word, so to speak. :)
>
> > Considering this is done, can you issue your conditional tag so I will
> > incorporate it in v3?
>
> No need, really. Again, unless Dominik thinks otherwise.

I think that what is wanted to have to get his tag.

Thanks for review, both of you, guys!

--
With Best Regards,
Andy Shevchenko