Re: [PATCH v2 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p()

Andy Shevchenko
2022-11-03T17:13:55Z

On Thu, Nov 03, 2022 at 06:03:24PM +0100, Dominik Brodowski wrote:
> Am Thu, Nov 03, 2022 at 06:46:44PM +0200 schrieb Andy Shevchenko:

...

> > -
> > - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> > - res = s->cb_dev->bus->resource[i];
> > -#else
> > - pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
> > #endif
> > +
> > + pci_bus_for_each_resource_p(s->cb_dev->bus, res) {
> > if (!res)
> > continue;
>
> Doesn't this remove the proper iterator for X86? Even if that is the right
> thing to do, it needs an explict explanation.

I dunno what was in 2010, but reading code now I have found no differences in
the logic on how resources are being iterated in these two pieces of code.

But fine, I will add a line to a commit message about this change.

Considering this is done, can you issue your conditional tag so I will
incorporate it in v3?

--
With Best Regards,
Andy Shevchenko