From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F049BC4332F for ; Thu, 3 Nov 2022 14:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbiKCOSQ (ORCPT ); Thu, 3 Nov 2022 10:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231404AbiKCORy (ORCPT ); Thu, 3 Nov 2022 10:17:54 -0400 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC57326DC; Thu, 3 Nov 2022 07:16:47 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id bk15so2937822wrb.13; Thu, 03 Nov 2022 07:16:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=80B2b1bMn1FZmClWYd3FX65ywdaYJT+10GImN40lUiM=; b=YtiSEalBmGnnNRutR6EHaozR1TvbreGBqzWUT6T+5vejXH40Dj9xEEg7PQivKifH+u yTUItl/Wxqz7LpYeOs2ZroRxSGVdVGyLcHkUzJX5DaxM4mM71qs0y5x0bsIDpaqvgNa1 Y3Ahk3zvSJcwF2zOUD5d2/GHtGzhgOxSWL3Bt48bDhBBVhCP8lJMDo71sbwKEDXDkS+S emY4D2Np80NB5Q5N6HA/4gLFAEDkOk0Ben4EcrkXXRa7AhnBv7S20PdLf8YS0lhbmoEv q4wISvqGWDlXvsxga8vCd1iDodODIB051CfXgoqYSXxOwG0ujuMj5/mfmrzg7r6kiVu2 owuw== X-Gm-Message-State: ACrzQf3s9YgT7dHW95H3VJbsTBQy03LqntsLJVU45yWUr2QuD1ckWxpF AWBPqtC58D/me8cQvh+nJoE= X-Google-Smtp-Source: AMsMyM7on/BQsGLd9/ikyaypEllg8CbAEx0xNHuurebxCLJjdkjrBl+DoN6mhjxyOUzqX2ta/wscow== X-Received: by 2002:a5d:4cca:0:b0:236:aecc:60cb with SMTP id c10-20020a5d4cca000000b00236aecc60cbmr18748510wrt.11.1667485006250; Thu, 03 Nov 2022 07:16:46 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id l6-20020a5d5266000000b00236a16c00ffsm1032357wrc.43.2022.11.03.07.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 07:16:45 -0700 (PDT) Date: Thu, 3 Nov 2022 14:16:36 +0000 From: Wei Liu To: "Michael Kelley (LINUX)" Cc: Jinank Jain , Jinank Jain , KY Srinivasan , Haiyang Zhang , "sthemmin@microsoft.com" , "wei.liu@kernel.org" , Dexuan Cui , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "arnd@arndb.de" , "peterz@infradead.org" , "jpoimboe@kernel.org" , "seanjc@google.com" , "kirill.shutemov@linux.intel.com" , "ak@linux.intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" Subject: Re: [PATCH v2 4/5] hv: Enable vmbus driver for nested root partition Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 03:30:35AM +0000, Michael Kelley (LINUX) wrote: > From: Jinank Jain Sent: Wednesday, November 2, 2022 9:36 AM > > > > Currently VMBus driver is not initialized for root partition but we need > > to enable the VMBus driver for nested root partition. This is required > > to expose VMBus devices to the L2 guest in the nested setup. > > > > Signed-off-by: Jinank Jain > > --- > > drivers/hv/vmbus_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > > index 8b2e413bf19c..2f0cf75e811b 100644 > > --- a/drivers/hv/vmbus_drv.c > > +++ b/drivers/hv/vmbus_drv.c > > @@ -2723,7 +2723,7 @@ static int __init hv_acpi_init(void) > > if (!hv_is_hyperv_initialized()) > > return -ENODEV; > > > > - if (hv_root_partition) > > + if (hv_root_partition && !hv_nested) > > Note that this code must compile and run when Linux is built > to run as a guest on Hyper-V for ARM64. There's currently > no definition for hv_nested on the ARM64 side, so the compile > will fail. But per my comments in Patch 1 in this series, using the > same technique as for hv_root_partition in hv_common.c should > solve the ARM64 problem as well. Jinank, you can use the following commands to cross-compile Linux. make ARCH=arm64 mshv_defconfig make -j$(nproc) ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- Image I think there are some follow-up patches in the internal tree which fixed the arm64 build. You may be able to squash some of those patches into series. Thanks, Wei.