Re: [PATCH v5 RESEND] soc: nuvoton: Add SoC info driver for WPCM450

["Jonathan Neuschäfer" <j.neuschaefer@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 2155 bytes --]

On Thu, Nov 03, 2022 at 09:11:08AM +0200, Tomer Maimon wrote:
> Hi Jonathan,
> 
> Thanks for your patch.
> 
> On Thu, 3 Nov 2022 at 01:09, Joel Stanley <joel@jms.id.au> wrote:
> >
> > On Mon, 31 Oct 2022 at 22:40, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> > >
> > > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> > > information such as the SoC revision.
[...]
> > > +++ b/drivers/soc/nuvoton/Kconfig
> > > @@ -0,0 +1,11 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +menuconfig WPCM450_SOC
> > > +       tristate "Nuvoton WPCM450 SoC driver"
> > > +       default y if ARCH_WPCM450
> > > +       select SOC_BUS
> >
> > Sorry for not noticing this earlier. This is a bit confusing. If we
> > have a menu option, the soc driver should appear under it. Or we could
> > do without the menu all together, as there's only one driver so far.

Good point.

> >
> > We also should select REGMAP, as you're using it,

I'll add it.

> > and hide the option behind ARCH_WPCM450 || COMPILE_TEST.
> >
> > How about this:
> >
> > if ARCH_WPCM450 || COMPILE_TEST
> These days we working on LPC BPC driver for NPCM7xx and NPCM8xx that
> will be placed in nuvoton soc folder.
> we will use:
> 
> if ARCH_NPCM || COMPILE_TEST
> 
> menu "NPCM SoC drivers"

That sounds reasonable, I'll do something similar.

> Maybe you should remove
> if ARCH_WPCM450 || COMPILE_TEST
> 
> and add ARCH_WPCM450 dependency in the WPCM450_SOCINFO driver configuration.

The WPCM450_SOCINFO driver would build fine on other NPCM SoC, it just
wouldn't be very useful, so I think the current "default y if ARCH_WPCM450"
solution is sufficient.

> 
> >
> > config WPCM450_SOCINFO
> >         tristate "Nuvoton WPCM450 SoC driver"
> >         default y if ARCH_WPCM450
> >         select SOC_BUS
> >         select REGMAP
> >         help
> >           Say Y here to compile the SoC information driver for Nuvoton
> >           WPCM450 SoCs.
> >
> >           This driver provides information such as the SoC model and
> >           revision.
> >
> > endif


Thank you both,
Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]