From: Heiko Carstens <hca@linux.ibm.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] random: do not include <asm/archrandom.h> from random.h
Date: Fri, 4 Nov 2022 15:34:05 +0100 [thread overview]
Message-ID: <Y2Ui3fr7pwKGJzM3@osiris> (raw)
In-Reply-To: <20221103121740.6684-1-Jason@zx2c4.com>
On Thu, Nov 03, 2022 at 01:17:40PM +0100, Jason A. Donenfeld wrote:
> The <asm/archrandom.h> header is a random.c private detail, not
> something to be called by other code. As such, don't make it
> automatically available by way of random.h.
>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> arch/powerpc/kernel/setup-common.c | 1 +
> arch/s390/kernel/setup.c | 1 +
> drivers/char/hw_random/s390-trng.c | 1 +
> drivers/char/random.c | 1 +
> include/linux/random.h | 2 --
> 5 files changed, 4 insertions(+), 2 deletions(-)
Acked-by: Heiko Carstens <hca@linux.ibm.com>
prev parent reply other threads:[~2022-11-04 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 1:08 [PATCH v2] random: do not include <asm/archrandom.h> from random.h Jason A. Donenfeld
2022-11-03 8:23 ` Christophe Leroy
2022-11-03 12:17 ` [PATCH v3] " Jason A. Donenfeld
2022-11-04 14:34 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Ui3fr7pwKGJzM3@osiris \
--to=hca@linux.ibm.com \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox