From: Uladzislau Rezki <urezki@gmail.com>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: paulmck@kernel.org, Uladzislau Rezki <urezki@gmail.com>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] rcu/kfree: Do not request RCU when not needed
Date: Fri, 4 Nov 2022 15:39:09 +0100 [thread overview]
Message-ID: <Y2UkDZDKXOaH9jA0@pc638.lan> (raw)
In-Reply-To: <B78EFE6F-D479-4F96-89CC-E19CA4146FF8@joelfernandes.org>
> >>
> >> Or am I missing something here?
> >
> > Yeah I am with Paul on this, NAK on “blocking in kworker” instead of “checking for grace period + queuing either regular work or RCU work”. Note that blocking also adds a pointless and fully avoidable scheduler round trip.
>
> As a side note, it’s notable how nicely this work evolved over the years thanks to Vlad and all of y’all’s work. For instance, flooding pages with kfree pointers and grace period polling was not something even invented back when kfree_rcu was a simple wrapper. Now it soon will be actually freeing memory faster, by avoiding waiting on RCU when not needed! And of course this is all happening probably because we wanted RCU to be lazy in nocb is a nice side effect of that effort ;-)
>
Yep. We want sometimes everything to be lazy :)
--
Uladzislau Rezki
next prev parent reply other threads:[~2022-11-04 14:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 13:28 [PATCH RFC] rcu/kfree: Do not request RCU when not needed Joel Fernandes (Google)
2022-10-29 13:31 ` Joel Fernandes
2022-11-02 12:37 ` Uladzislau Rezki
2022-11-02 16:13 ` Joel Fernandes
2022-11-02 16:35 ` Paul E. McKenney
2022-11-02 17:24 ` Uladzislau Rezki
2022-11-02 17:29 ` Joel Fernandes
2022-11-02 18:31 ` Uladzislau Rezki
2022-11-02 18:49 ` Paul E. McKenney
2022-11-02 19:46 ` Joel Fernandes
2022-11-02 20:28 ` Paul E. McKenney
2022-11-02 21:26 ` Joel Fernandes
2022-11-02 22:35 ` Paul E. McKenney
2022-11-03 12:44 ` Uladzislau Rezki
2022-11-03 13:05 ` Uladzislau Rezki
2022-11-03 16:34 ` Paul E. McKenney
2022-11-03 17:52 ` Paul E. McKenney
2022-11-03 12:41 ` Uladzislau Rezki
2022-11-03 17:51 ` Paul E. McKenney
2022-11-03 18:36 ` Joel Fernandes
2022-11-03 18:43 ` Joel Fernandes
2022-11-04 14:39 ` Uladzislau Rezki [this message]
2022-11-04 14:35 ` Uladzislau Rezki
[not found] ` <CAEXW_YQWYfJPpeXoV0ZDGC7Kd585LJ+h2YbKfB3unDDZinxTRQ@mail.gmail.com>
2022-11-03 12:54 ` Uladzislau Rezki
2022-11-02 17:30 ` Uladzislau Rezki
2022-11-02 18:32 ` Paul E. McKenney
2022-11-02 19:51 ` Joel Fernandes
2022-11-02 16:11 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2UkDZDKXOaH9jA0@pc638.lan \
--to=urezki@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox