From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3EDC4332F for ; Sat, 5 Nov 2022 11:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbiKELHG (ORCPT ); Sat, 5 Nov 2022 07:07:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbiKELHB (ORCPT ); Sat, 5 Nov 2022 07:07:01 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35413FCED for ; Sat, 5 Nov 2022 04:07:00 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id l14so10160966wrw.2 for ; Sat, 05 Nov 2022 04:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Esm2JJwSNEtII9L8+muwgLgVSZNMbFgxAhVuFsoBzJo=; b=c5+aIiBdvqAKKrDFxzewBNxEU0MCXXczY9NEnI9ntcRQWR59O6mh3ZcLogXk+k5/s7 TUw5r7fWxjURengwrylerkNusffeCAOXcfnIyj48vVJyTaSc6jX/XFLPP1z3GDjUdrM0 BBzo8BfXgu6GNnp+iiwJCrdq+f6S2BOURpsDs5iWyki6KCspnwh0tvPNNuJoQxzPxoQv VE7knBtABQyBW4C7Zpe6kgoWLNH2V7THs63pkR+wS79sq77bePn3OrBm9SKvrguZt762 tnNvjPRFUdU8kdM1Kc/UjccG6GuNamLgeevFqMtRPwlUVVRLGscaMa1YdUNRD1jT60hx LshA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Esm2JJwSNEtII9L8+muwgLgVSZNMbFgxAhVuFsoBzJo=; b=SuOY8k8LBFFBSaE2PodB16JhsBa6dtwTHFUDY59oj98vOhKcQP7hkx6VTaZgWY7Tvh MmYDU65lXXAH8FUZMlQynf7UkO+tuxkUFRKf86K68y3v9BgTK1IUHYo2gxO3d9gcd0cC YTn8p+WJ77NLRqMXTBxtKFxxpFdp5bzgIe6L3KwDmN6GiQkFVlxJ7F6pSXakKivWqO1a MBZ1+yHxRDSXBap6IzhdEyi/5uxM+xmYVVP66uNB9meBkSklo1qulhs2ZAZcUELqduBH 1kFaH03Q3UdJpkDwi6YCzO95AqyvCZDf6oNtcz/+GTBlaN5q2YsRnQ2mum60FC5aWZTw PKtQ== X-Gm-Message-State: ACrzQf3IvpcxqLO4QL5AqmUbj324bkFBXLCGzu8gFHECJcG6kjrnr0C3 w+yUcS9uMLrj09tNY9p0QipdZQ== X-Google-Smtp-Source: AMsMyM6bWqNuvE/LnoopQ1YGfhnMh3Fy0fDRMD4RQRLm7T1BJFBq0X19aIWJyJU5F5wGAB58SPrnKA== X-Received: by 2002:adf:e64e:0:b0:236:76a9:446 with SMTP id b14-20020adfe64e000000b0023676a90446mr26046252wrn.696.1667646418698; Sat, 05 Nov 2022 04:06:58 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id iv9-20020a05600c548900b003cf87623c16sm6196172wmb.4.2022.11.05.04.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 04:06:58 -0700 (PDT) Date: Sat, 5 Nov 2022 11:06:56 +0000 From: Phillip Potter To: Michael Straube Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: convert three functions to bool Message-ID: References: <20221105093916.8255-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221105093916.8255-1-straube.linux@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 05, 2022 at 10:39:16AM +0100, Michael Straube wrote: > The functions > > is_client_associated_to_ap() > is_client_associated_to_ibss() > is_IBSS_empty() > > return boolean values. Convert their return type to bool and replace > _FAIL, which is defined as 0, with false. Another step to get rid of > _SUCCESS / _FAIL. > > Signed-off-by: Michael Straube > --- > drivers/staging/r8188eu/core/rtw_wlan_util.c | 18 +++++++++--------- > drivers/staging/r8188eu/include/rtw_mlme_ext.h | 6 +++--- > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_wlan_util.c b/drivers/staging/r8188eu/core/rtw_wlan_util.c > index e50631848cab..c95438a12b59 100644 > --- a/drivers/staging/r8188eu/core/rtw_wlan_util.c > +++ b/drivers/staging/r8188eu/core/rtw_wlan_util.c > @@ -331,35 +331,35 @@ u16 get_beacon_interval(struct wlan_bssid_ex *bss) > return le16_to_cpu(val); > } > > -int is_client_associated_to_ap(struct adapter *padapter) > +bool is_client_associated_to_ap(struct adapter *padapter) > { > struct mlme_ext_priv *pmlmeext; > struct mlme_ext_info *pmlmeinfo; > > if (!padapter) > - return _FAIL; > + return false; > > pmlmeext = &padapter->mlmeextpriv; > pmlmeinfo = &pmlmeext->mlmext_info; > > if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)) > return true; > - else > - return _FAIL; > + > + return false; > } > > -int is_client_associated_to_ibss(struct adapter *padapter) > +bool is_client_associated_to_ibss(struct adapter *padapter) > { > struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; > struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; > > if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x03) == WIFI_FW_ADHOC_STATE)) > return true; > - else > - return _FAIL; > + > + return false; > } > > -int is_IBSS_empty(struct adapter *padapter) > +bool is_IBSS_empty(struct adapter *padapter) > { > unsigned int i; > struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; > @@ -367,7 +367,7 @@ int is_IBSS_empty(struct adapter *padapter) > > for (i = IBSS_START_MAC_ID; i < NUM_STA; i++) { > if (pmlmeinfo->FW_sta_info[i].status == 1) > - return _FAIL; > + return false; > } > return true; > } > diff --git a/drivers/staging/r8188eu/include/rtw_mlme_ext.h b/drivers/staging/r8188eu/include/rtw_mlme_ext.h > index e234a3b9af6f..7652e72a03f4 100644 > --- a/drivers/staging/r8188eu/include/rtw_mlme_ext.h > +++ b/drivers/staging/r8188eu/include/rtw_mlme_ext.h > @@ -432,9 +432,9 @@ void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, > u8 *get_my_bssid(struct wlan_bssid_ex *pnetwork); > u16 get_beacon_interval(struct wlan_bssid_ex *bss); > > -int is_client_associated_to_ap(struct adapter *padapter); > -int is_client_associated_to_ibss(struct adapter *padapter); > -int is_IBSS_empty(struct adapter *padapter); > +bool is_client_associated_to_ap(struct adapter *padapter); > +bool is_client_associated_to_ibss(struct adapter *padapter); > +bool is_IBSS_empty(struct adapter *padapter); > > unsigned char check_assoc_AP(u8 *pframe, uint len); > > -- > 2.38.0 > Hi Michael, Thanks for the patch. Just my personal opinion, but I would prefer to keep the return type as int, and have 0 for success and then _FAIL replaced with an appropriate error code depending on the circumstance, (e.g. -ENOMEM). This is generally the convention elsewhere in the kernel. Others may not agree though. All the best, Phil