From: Corey Minyard <minyard@acm.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH] ipmi/watchdog: Include <linux/kstrtox.h> when appropriate
Date: Sat, 5 Nov 2022 19:30:35 -0500 [thread overview]
Message-ID: <Y2cAKyqilb7v9tFi@minyard.net> (raw)
In-Reply-To: <37daa028845d90ee77f1e547121a051a983fec2e.1667647002.git.christophe.jaillet@wanadoo.fr>
On Sat, Nov 05, 2022 at 12:16:54PM +0100, Christophe JAILLET wrote:
> The kstrto<something>() functions have been moved from kernel.h to
> kstrtox.h.
>
> So, in order to eventually remove <linux/kernel.h> from <linux/watchdog.h>,
> include the latter directly in the appropriate files.
This is in my queue. Thanks.
-corey
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index 5b4e677929ca..47365150e431 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -23,6 +23,7 @@
> #include <linux/init.h>
> #include <linux/completion.h>
> #include <linux/kdebug.h>
> +#include <linux/kstrtox.h>
> #include <linux/rwsem.h>
> #include <linux/errno.h>
> #include <linux/uaccess.h>
> --
> 2.34.1
>
prev parent reply other threads:[~2022-11-06 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 11:16 [PATCH] ipmi/watchdog: Include <linux/kstrtox.h> when appropriate Christophe JAILLET
2022-11-06 0:30 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2cAKyqilb7v9tFi@minyard.net \
--to=minyard@acm.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox