From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BA4C4332F for ; Mon, 7 Nov 2022 07:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbiKGHa7 (ORCPT ); Mon, 7 Nov 2022 02:30:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231487AbiKGHam (ORCPT ); Mon, 7 Nov 2022 02:30:42 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F6292AD5 for ; Sun, 6 Nov 2022 23:30:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0D9B3B80B8D for ; Mon, 7 Nov 2022 07:30:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43032C433C1; Mon, 7 Nov 2022 07:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667806204; bh=dARsHMvO/jjfwb1xJiZ9If4+NzELmasjWyqxIZwCW2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fcLtBatZU2QkJMt06HGMQYnquCFS/c3U9hUYPQ4xrLSt1g4fkh6pMZkJOQrwo7AYb pm3GeWt0Y6hWORLycAyDboYwMyz2Cd4a64IryL0eDPaYNAh+qKvXhT2pG6kXBtYffZ tUOseyHaD8zEwJiivZ8ermjBMn5BBk/NKmYBsEKdFz/kqHWZmhwgpPKYlKx+B6oHdH tgrWTdBWydzEQ30guBTrUcBjM4lr1Scs2RmceWsLKVTkzNQdrInjGq4izrgbs4w8w9 BAXEWz4dm0Zf9MKqRnIcGazHPZvbIhJ6fJKjRaZ7kEdGsH7v8xTa5tKrSihE/J3nut HN3TNk9i+3q9g== Date: Mon, 7 Nov 2022 09:29:51 +0200 From: Mike Rapoport To: Rebecca Mckeever Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v4 0/5] memblock tests: add tests for memblock_alloc_exact_nid_raw Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2022 at 12:28:04AM -0600, Rebecca Mckeever wrote: > These patches add tests for memblock_alloc_exact_nid_raw(). There are two > sets of tests: range tests and NUMA tests. The range tests use a normal > (i.e., UMA) simulated physical memory and set the nid to NUMA_NO_NODE. The > NUMA tests use a simulated physical memory that is set up with multiple > NUMA nodes. Additionally, most of the NUMA tests set nid != NUMA_NO_NODE. > > For the range tests, the TEST_F_EXACT flag is used to run the same set of > range tests used for memblock_alloc_try_nid_raw(). The NUMA tests have the > same setup as the corresponding test for memblock_alloc_try_nid_raw(), but > several of the memblock_alloc_exact_nid_raw() tests fail to allocate > memory in setups where the memblock_alloc_try_nid_raw() test would > allocate memory. Also, some memblock_alloc_exact_nid_raw() tests drop the > lower limit of the requested range in order to allocate within the > requested node, but the same setup in a memblock_alloc_try_nid_raw() test > allocates within the requested range. Applied, thanks! -- Sincerely yours, Mike.