From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B33C4332F for ; Mon, 7 Nov 2022 12:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231941AbiKGMIG (ORCPT ); Mon, 7 Nov 2022 07:08:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbiKGMH6 (ORCPT ); Mon, 7 Nov 2022 07:07:58 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B7811ADB0; Mon, 7 Nov 2022 04:07:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B67060ED6; Mon, 7 Nov 2022 12:07:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5EA5C4347C; Mon, 7 Nov 2022 12:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667822876; bh=bAveuJlCOoCX/Gy1WjcK67NcvEunw1tl9ZBr69hFsgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bx6hRpWkz+KS0BVBbB7z+4BGcKQJjYMTFtjXLf8rVoUc1xgfrsbrGSoN5YtpfO6lb 7iqPuH6whzRDBMeVyFtfd3PurimQ57+VZinboN1262PTyDfvRV/A6BRQOeQdfNbmhC omvL+UHuWpSNLros6gHSEUCskf1PRduWCclh1S1o= Date: Mon, 7 Nov 2022 13:07:52 +0100 From: Greg KH To: Slark Xiao Cc: mani@kernel.org, loic.poulain@linaro.org, dnlplm@gmail.com, yonglin.tan@outlook.com, fabio.porcedda@gmail.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Re: Re: [PATCH v2] bus: mhi: host: pci_generic: Add macro for some VIDs Message-ID: References: <20221107084826.8888-1-slark_xiao@163.com> <28f1e702.28d7.184516dbbbb.Coremail.slark_xiao@163.com> <5b96b2e2.3a97.18451a061a3.Coremail.slark_xiao@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b96b2e2.3a97.18451a061a3.Coremail.slark_xiao@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2022 at 06:26:16PM +0800, Slark Xiao wrote: > > > > > > > > > > > > > > > > Why all the blank lines? > At 2022-11-07 17:53:57, "Greg KH" wrote: > >On Mon, Nov 07, 2022 at 05:30:56PM +0800, Slark Xiao wrote: > >As I said, this is just a define, not a macro at all. > > > >> And could you give your comments in previous patch, not the 'final' one? > > > >I do not understand, what previous patrch? What "final" one? What is > >the "latest" patch? > previous patch: > https://lore.kernel.org/lkml/20221027115123.5326-1-slark_xiao@163.com/ > https://lore.kernel.org/lkml/20221028023711.4196-1-slark_xiao@163.com/ > https://lore.kernel.org/lkml/20221102024437.15248-1-slark_xiao@163.com/ > > 'final' patch: > https://lore.kernel.org/lkml/20221107084826.8888-1-slark_xiao@163.com/ > https://lore.kernel.org/lkml/20221101015858.6777-1-slark_xiao@163.com/ That's 2 different versions, with a total of 3. > > The 'final' patch was committed according to the advice of the feature > maintainer. > > > >> In another pci_ids patch, you break it in v3 and break it here again in v2. > > > >I broke what? > You could have voiced out such comment in V1, V2 before the 'final'. We all review patches when we can. There is no rule that people can not comment on newer patches, or older ones. In fact, it would be wonderful if you could take some time and review patches from others. It would help your understanding of the code and how the kernel development process works. thanks, greg k-h