From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0D5C4332F for ; Mon, 7 Nov 2022 12:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230313AbiKGMlM (ORCPT ); Mon, 7 Nov 2022 07:41:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbiKGMlJ (ORCPT ); Mon, 7 Nov 2022 07:41:09 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E2B11B7AF; Mon, 7 Nov 2022 04:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667824868; x=1699360868; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JrFUNJUR+xfBmaFKXTf1XB9n1c5qjS+akAmoKJWoy8o=; b=CTKRrZWcjIFUT/nYqSTFt6GzEXbBA0wKj7SswhMGSAxolaL8Ldkx41Sj +avB/Vfaks6OJf6CmZ/GVyAnB2H9DUF2PoIE+hZLgra6AaycwWhhl5Le/ zwdnbLIoCk53JWl6Ypzd/xhyjPZtwF0PwLBnHr4vmgx2b48rIhtRYjYd4 /SpcHazLDp4dNK4bR7B5mXNUKQbjUoOkamFR+qXYMJekkmmPA5Cp5GCA2 XXCF/3yNrv7rX2mHJo/dHI2wBegpzJJNCE8eANt4IOpIVdp66Qq3xtOgi jkM0vCIR7YrkVzk+C5hWdtvHoAMEfuRMnc047N295es8Uv1Il/MsI1WHJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="311533783" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="311533783" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 04:41:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="669123382" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="669123382" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 07 Nov 2022 04:41:05 -0800 Received: by black.fi.intel.com (Postfix, from userid 1001) id 59A19155; Mon, 7 Nov 2022 14:41:29 +0200 (EET) Date: Mon, 7 Nov 2022 14:41:29 +0200 From: Mika Westerberg To: Rajat Khandelwal Cc: michael.jamet@intel.com, YehezkelShB@gmail.com, andreas.noever@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] thunderbolt: Add wake on connect/disconnect on USB4 ports Message-ID: References: <20221101115042.248187-1-rajat.khandelwal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221101115042.248187-1-rajat.khandelwal@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 05:20:42PM +0530, Rajat Khandelwal wrote: > Wake on connect/disconnect is only supported while runtime suspend > for now, which is obviously necessary. It is also not inherently > desired for the system to wakeup on thunderbolt/USB4 hot plug events. > However, we can still make user in control of waking up the system > in the events of hot plug/unplug. > This patch adds 'wakeup' attribute under 'usb4_portX/power' sysfs > attribute and only enables wakes on connect/disconnect to the > respective port when 'wakeup' is set to 'enabled'. The attribute > is set to 'disabled' by default. > > Signed-off-by: Rajat Khandelwal > Reviewed-by: Mika Westerberg Applied to thunderbolt.git/next, thanks!