[PATCH] mfd: intel_soc_pmic: allow COMPILE_TEST or I2C_DESIGNWARE_PLATFORM

[PATCH] mfd: intel_soc_pmic: allow COMPILE_TEST or I2C_DESIGNWARE_PLATFORM

[Randy Dunlap]

Linus expressed a desire to have intel_soc_pmic_crc.o (INTEL_SOC_PMIC,
for Crystal Cove) be built on an "allmodconfig" build, when
I2C_DESIGNWARE_PLATFORM=m, to enhance build test coverage.

The PMIC driver won't work in this case since it requires
I2C_DESIGNWARE_PLATFORM=y to operate properly, but adding
"|| COMPILE_TEST" does improve the build test coverage.

Link: https://lore.kernel.org/all/CAHk-=wg=hh8xkPjiySnjAyR66AG64eyZ1Y9gHw+MCs8uuSZReA@mail.gmail.com/
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
---
 drivers/mfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -603,7 +603,7 @@ config INTEL_SOC_PMIC
 	bool "Support for Crystal Cove PMIC"
 	depends on HAS_IOMEM && I2C=y && GPIOLIB && COMMON_CLK
 	depends on (X86 && ACPI) || COMPILE_TEST
-	depends on I2C_DESIGNWARE_PLATFORM=y
+	depends on I2C_DESIGNWARE_PLATFORM=y || COMPILE_TEST
 	select MFD_CORE
 	select REGMAP_I2C
 	select REGMAP_IRQ

Re: [PATCH] mfd: intel_soc_pmic: allow COMPILE_TEST or I2C_DESIGNWARE_PLATFORM

[Hans de Goede]

Hi,

On 11/1/22 06:54, Randy Dunlap wrote:
> Linus expressed a desire to have intel_soc_pmic_crc.o (INTEL_SOC_PMIC,
> for Crystal Cove) be built on an "allmodconfig" build, when
> I2C_DESIGNWARE_PLATFORM=m, to enhance build test coverage.
> 
> The PMIC driver won't work in this case since it requires
> I2C_DESIGNWARE_PLATFORM=y to operate properly, but adding
> "|| COMPILE_TEST" does improve the build test coverage.
> 
> Link: https://lore.kernel.org/all/CAHk-=wg=hh8xkPjiySnjAyR66AG64eyZ1Y9gHw+MCs8uuSZReA@mail.gmail.com/
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/mfd/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -603,7 +603,7 @@ config INTEL_SOC_PMIC
>  	bool "Support for Crystal Cove PMIC"
>  	depends on HAS_IOMEM && I2C=y && GPIOLIB && COMMON_CLK
>  	depends on (X86 && ACPI) || COMPILE_TEST
> -	depends on I2C_DESIGNWARE_PLATFORM=y
> +	depends on I2C_DESIGNWARE_PLATFORM=y || COMPILE_TEST
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
> 

Re: [PATCH] mfd: intel_soc_pmic: allow COMPILE_TEST or I2C_DESIGNWARE_PLATFORM

[Lee Jones]

On Mon, 31 Oct 2022, Randy Dunlap wrote:

> Linus expressed a desire to have intel_soc_pmic_crc.o (INTEL_SOC_PMIC,
> for Crystal Cove) be built on an "allmodconfig" build, when
> I2C_DESIGNWARE_PLATFORM=m, to enhance build test coverage.
> 
> The PMIC driver won't work in this case since it requires
> I2C_DESIGNWARE_PLATFORM=y to operate properly, but adding
> "|| COMPILE_TEST" does improve the build test coverage.
> 
> Link: https://lore.kernel.org/all/CAHk-=wg=hh8xkPjiySnjAyR66AG64eyZ1Y9gHw+MCs8uuSZReA@mail.gmail.com/
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
>  drivers/mfd/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]