public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ceph: fix memory leak in mount error path when using test_dummy_encryption
@ 2022-11-03 15:36 Luís Henriques
  2022-11-04  6:40 ` kernel test robot
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Luís Henriques @ 2022-11-03 15:36 UTC (permalink / raw)
  To: Xiubo Li, Ilya Dryomov, Jeff Layton
  Cc: ceph-devel, linux-kernel, Luís Henriques

Because ceph_init_fs_context() will never be invoced in case we get a
mount error, destroy_mount_options() won't be releasing fscrypt resources
with fscrypt_free_dummy_policy().  This will result in a memory leak.  Add
an invocation to this function in the mount error path.

Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
 fs/ceph/super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/ceph/super.c b/fs/ceph/super.c
index 2224d44d21c0..6b9fd04b25cd 100644
--- a/fs/ceph/super.c
+++ b/fs/ceph/super.c
@@ -1362,6 +1362,7 @@ static int ceph_get_tree(struct fs_context *fc)
 
 	ceph_mdsc_close_sessions(fsc->mdsc);
 	deactivate_locked_super(sb);
+	fscrypt_free_dummy_policy(&fsc->fsc_dummy_enc_policy);
 	goto out_final;
 
 out:

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-11-08  5:58 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03 15:36 [PATCH] ceph: fix memory leak in mount error path when using test_dummy_encryption Luís Henriques
2022-11-04  6:40 ` kernel test robot
2022-11-04  9:47   ` Luís Henriques
2022-11-04 10:02     ` Chen, Rong A
2022-11-04 11:21       ` Luís Henriques
2022-11-04 14:05 ` kernel test robot
2022-11-07  7:47 ` Xiubo Li
2022-11-07 10:23   ` Luís Henriques
2022-11-07 11:06     ` Xiubo Li
2022-11-07 14:19       ` Luís Henriques
2022-11-08  5:56         ` Xiubo Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox